From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755569AbbLDIoG (ORCPT ); Fri, 4 Dec 2015 03:44:06 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36631 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755455AbbLDIoC (ORCPT ); Fri, 4 Dec 2015 03:44:02 -0500 Date: Fri, 4 Dec 2015 08:43:58 +0000 From: Lee Jones To: "Andrew F. Davis" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Linus Walleij , Alexandre Courbot , Samuel Ortiz , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 0/5] mfd: tps65912: Driver rewrite with DT support Message-ID: <20151204084358.GD26902@x1> References: <1447869580-10416-1-git-send-email-afd@ti.com> <20151124162624.GI807@x1> <56606558.9080200@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56606558.9080200@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 03 Dec 2015, Andrew F. Davis wrote: > On 11/24/2015 10:26 AM, Lee Jones wrote: > >On Wed, 18 Nov 2015, Andrew F. Davis wrote: > > > >>In an effort to cleanup this driver and add Device Tree support > >>the driver has been rewritten based on new driver styles and > >>modern kernel driver helpers. This has nearly halved the lines > >>of code while keeping all previous functionality. > >> > >>Platform file based initialization has been dropped as there is > >>no examples of this use in the kernel. > >> > >>v1 can be found here: [1] v2: [2] v3: [3] v4: [4] v5: [5] v6: [6] > >> > >>Changes from v6: > >> - Removed compatible strings from DT sub-nodes > >> - Rearranged DT bindings > >> - Small fixes > >> > >>Changes from v5: > >> - Small formatting changes to DT Docs > >> - Converted to_tps65912_gpio from macro to inline function > >> > >>Changes from v4: > >> - Use mfd core to add sub-devices > >> > >>Changes from v3: > >> - Reorganized regulator driver and related DT node > >> - Other small fixes as discussed in v3 thread > >> > >>Changes from v2: > >> - Split the series further into subsystems > >> > >>Changes from v1: > >> - Split the rewrite into delete/create patches > >> - Several small fixes as discussed in v1 thread > >> > >>[1] http://www.spinics.net/lists/devicetree/msg93863.html > >>[2] http://www.spinics.net/lists/devicetree/msg95003.html > >>[3] http://www.spinics.net/lists/devicetree/msg95133.html > >>[4] http://www.spinics.net/lists/devicetree/msg96109.html > >>[5] http://www.spinics.net/lists/devicetree/msg100601.html > >>[6] https://lkml.org/lkml/2015/10/30/690 > >> > >>Andrew F. Davis (5): > >> Documentation: tps65912: Add DT bindings for the TPS65912 PMIC > >> mfd: tps65912: Remove old driver in preparation for new driver > >> mfd: tps65912: Add driver for the TPS65912 PMIC > >> regulator: tps65912: Add regulator driver for the TPS65912 PMIC > >> gpio: tps65912: Add GPIO driver for the TPS65912 PMIC > >> > >> Documentation/devicetree/bindings/mfd/tps65912.txt | 50 ++ > >> drivers/gpio/Kconfig | 2 +- > >> drivers/gpio/gpio-tps65912.c | 317 ++++----- > >> drivers/mfd/Kconfig | 20 +- > >> drivers/mfd/Makefile | 3 +- > >> drivers/mfd/tps65912-core.c | 290 ++++----- > >> drivers/mfd/tps65912-i2c.c | 219 +++---- > >> drivers/mfd/tps65912-irq.c | 217 ------- > >> drivers/mfd/tps65912-spi.c | 219 +++---- > >> drivers/regulator/Kconfig | 2 +- > >> drivers/regulator/tps65912-regulator.c | 710 +++++---------------- > >> include/linux/mfd/tps65912.h | 208 +++--- > > > >Just waiting for the regulator Ack now, right? > > > > I believe so, is there a friendly way to poke Mark Brown so this doesn't > get caught in his filter? This is almost identical to the regulator he > applied the other day from me so I don't imagine there will be much problem > with this patch. Just repost the set with all the remaining Acks and explain in the cover letter that you're only missing one Ack. I can prod Mark from that point. > >> 12 files changed, 780 insertions(+), 1477 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/mfd/tps65912.txt > >> rewrite drivers/gpio/gpio-tps65912.c (74%) > >> rewrite drivers/mfd/tps65912-core.c (95%) > >> rewrite drivers/mfd/tps65912-i2c.c (93%) > >> delete mode 100644 drivers/mfd/tps65912-irq.c > >> rewrite drivers/mfd/tps65912-spi.c (92%) > >> rewrite drivers/regulator/tps65912-regulator.c (94%) > >> > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog