From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754020AbbLEQgZ (ORCPT ); Sat, 5 Dec 2015 11:36:25 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55054 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753723AbbLEQgX (ORCPT ); Sat, 5 Dec 2015 11:36:23 -0500 Date: Sat, 5 Dec 2015 08:36:22 -0800 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Andy Shevchenko , "Rafael J . Wysocki" , "linux-acpi@vger.kernel.org" , Vinod Koul , dmaengine , Thomas Gleixner , Jarkko Nikula , "linux-kernel@vger.kernel.org" , Mika Westerberg Subject: Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Message-ID: <20151205163622.GA2237@kroah.com> References: <1449265765-9393-1-git-send-email-andriy.shevchenko@linux.intel.com> <1449265765-9393-2-git-send-email-andriy.shevchenko@linux.intel.com> <20151205161416.GA1215@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 05, 2015 at 06:24:05PM +0200, Andy Shevchenko wrote: > On Sat, Dec 5, 2015 at 6:14 PM, Greg Kroah-Hartman > wrote: > > On Fri, Dec 04, 2015 at 11:49:17PM +0200, Andy Shevchenko wrote: > >> The users of BUS_NOTIFY_BIND_DRIVER have no chance to do any cleanup in case of > >> a probe failure. In the result there might be problems, such as some resources > >> that had been allocated will continue to be allocated and therefore lead to a > >> resource leak. > >> > >> Introduce a new notification to inform the subscriber that ->probe() failed. Do > >> the same in case of failed device_bind_driver() call. > > > > Ugh, I hate all these notifiers, but this one does make sense... > > Yeah, I'm not a fan of them either. > > > Signed-off-by: Greg Kroah-Hartman > > You meant Acked-by, didn't you? Either works :)