From: Ingo Molnar <mingo@kernel.org>
To: vincent.weaver@maine.edu, jolsa@redhat.com,
torvalds@linux-foundation.org, eranian@google.com,
tglx@linutronix.de, acme@redhat.com, ak@linux.intel.com,
peterz@infradead.org, linux-kernel@vger.kernel.org,
hpa@zytor.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86: Use INST_RETIRED.PREC_DIST for cycles: ppp
Date: Sun, 6 Dec 2015 14:11:02 +0100 [thread overview]
Message-ID: <20151206131102.GA12167@gmail.com> (raw)
In-Reply-To: <tip-4576ceaa56a86bd0c041c204d51c3f3ca582a49c@git.kernel.org>
* tip-bot for Andi Kleen <tipbot@zytor.com> wrote:
> Commit-ID: 4576ceaa56a86bd0c041c204d51c3f3ca582a49c
> Gitweb: http://git.kernel.org/tip/4576ceaa56a86bd0c041c204d51c3f3ca582a49c
> Author: Andi Kleen <ak@linux.intel.com>
> AuthorDate: Mon, 30 Nov 2015 16:28:09 -0800
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Fri, 4 Dec 2015 10:08:04 +0100
>
> perf/x86: Use INST_RETIRED.PREC_DIST for cycles:ppp
>
> Add a new 'three-p' precise level, that uses INST_RETIRED.PREC_DIST as
> base. The basic mechanism of abusing the inverse cmask to get all
> cycles works the same as before.
So this commit regressed on the follwing Intel Nehalem box:
processor : 15
vendor_id : GenuineIntel
cpu family : 6
model : 26
model name : Intel(R) Xeon(R) CPU X55600 @ 2.80GHz
stepping : 5
cpu MHz : 2793.000
cache size : 8192 KB
it has this perf bootup signature:
0.272504] Performance Events: PEBS fmt1+, 16-deep LBR, Nehalem events, Intel PMU driver.
0.281356] perf_event_intel: CPU erratum AAJ80 worked around
the symptom is that latest 'perf top' and 'perf record' produces no samples.
So I've removed this commit and the related Skylake commit from -tip:
4576ceaa56a8 perf/x86: Use INST_RETIRED.PREC_DIST for cycles:ppp
ac1e1d30cf90 perf/x86: Use INST_RETIRED.TOTAL_CYCLES_PS for cycles:pp for Skylake
you need to do better testing next time around. Note: if you resubmit the patches,
please also pick up the updates commit changelogs from the tip-bot emails, don't
use your original changelogs.
Also, I'm not convinced we need a new 'ppp' qualifier for any of this, why not
just replace 'pp' with this event - 'pp' is meant to be our most precise event.
Thanks,
Ingo
next prev parent reply other threads:[~2015-12-06 13:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 0:28 [PATCH 1/2] perf, x86: Use INST_RETIRED.TOTAL_CYCLES_PS for cycles:pp for Skylake Andi Kleen
2015-12-01 0:28 ` [PATCH 2/2] x86, perf: Use INST_RETIRED.PREC_DIST for cycles:ppp Andi Kleen
2015-12-01 13:41 ` Peter Zijlstra
2015-12-01 14:54 ` Andi Kleen
2015-12-01 14:55 ` Peter Zijlstra
2015-12-04 11:50 ` [tip:perf/core] perf/x86: Use INST_RETIRED.PREC_DIST for cycles: ppp tip-bot for Andi Kleen
2015-12-06 13:11 ` Ingo Molnar [this message]
2015-12-06 22:06 ` Peter Zijlstra
2015-12-07 6:48 ` Ingo Molnar
2015-12-07 10:26 ` Peter Zijlstra
2015-12-07 14:02 ` Arnaldo Carvalho de Melo
2015-12-07 14:12 ` Peter Zijlstra
2015-12-07 13:51 ` Peter Zijlstra
2015-12-08 5:36 ` Ingo Molnar
2015-12-08 8:50 ` Peter Zijlstra
2015-12-08 8:57 ` Peter Zijlstra
2015-12-08 13:27 ` Peter Zijlstra
2015-12-09 8:29 ` Ingo Molnar
2016-01-06 18:51 ` tip-bot for Andi Kleen
2015-12-01 13:19 ` [PATCH 1/2] perf, x86: Use INST_RETIRED.TOTAL_CYCLES_PS for cycles:pp for Skylake Peter Zijlstra
2015-12-04 11:50 ` [tip:perf/core] perf/x86: " tip-bot for Andi Kleen
2016-01-06 18:51 ` tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151206131102.GA12167@gmail.com \
--to=mingo@kernel.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).