From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932724AbbLGTJW (ORCPT ); Mon, 7 Dec 2015 14:09:22 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47808 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755713AbbLGTJU (ORCPT ); Mon, 7 Dec 2015 14:09:20 -0500 Date: Mon, 07 Dec 2015 14:09:18 -0500 (EST) Message-Id: <20151207.140918.1716095197130825314.davem@davemloft.net> To: narmstrong@baylibre.com Cc: nicolas.ferre@atmel.com, harini.katakam@xilinx.com, boris.brezillon@free-electrons.com, alexandre.belloni@free-electrons.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net 1/2] net: cadence: macb: Disable USRIO register on some platforms From: David Miller In-Reply-To: <1449485914-12883-2-git-send-email-narmstrong@baylibre.com> References: <1449485914-12883-1-git-send-email-narmstrong@baylibre.com> <1449485914-12883-2-git-send-email-narmstrong@baylibre.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 07 Dec 2015 11:09:19 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Neil Armstrong Date: Mon, 7 Dec 2015 11:58:33 +0100 > - regs_buff[12] = macb_or_gem_readl(bp, USRIO); > + if (!of_property_read_bool(bp->pdev->dev.of_node, "no-usrio")) { > + regs_buff[12] = macb_or_gem_readl(bp, USRIO); > + } Single statement basic blocks shall not be enclosed in curly braces.