linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Raj, Ashok" <ashok.raj@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V2] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process.
Date: Mon, 7 Dec 2015 18:46:40 -0500	[thread overview]
Message-ID: <20151207234639.GA81526@otc-brkl-03.jf.intel.com> (raw)
In-Reply-To: <20151207223427.GJ22248@pd.tnic>

On Mon, Dec 07, 2015 at 11:34:27PM +0100, Borislav Petkov wrote:
> 
> Box logs below.

Do you have the dmidecode strings to find which platform this is?

> 
> BIOS is doing funny cores enumeration:
> 
> node #0, CPUs 0-7
> node #1, CPUs 8-15
> node #2, CPUs 16-23
> node #3, CPUs 24-31
> 
> and then starts from node 0 again:
> 
>  .... node  #0, CPUs:    #32  #33  #34  #35  #36  #37  #38  #39
>  .... node  #1, CPUs:    #40  #41  #42  #43  #44  #45  #46  #47
>  .... node  #2, CPUs:    #48  #49  #50  #51  #52  #53  #54  #55
>  .... node  #3, CPUs:    #56  #57  #58  #59  #60  #61  #62  #63
> 
> So I went and offlined cores 5 and 34 which are on node 0.
> 
> Why node 0? Well, when I inject error type 0x10 which is
> 
> 0x00000010      Memory Uncorrectable non-fatal
> 
> it generates an MCE only on the node 0 cores. For that log see the end
> of this mail. The gist of it is that the CPUs on which #MC gets raised
> are the cores on node 0, i.e., 0-7 and 32-39.
> 
> Cores 5 and 34 are gone, of course.
> 
> I mean, even if the #MC gets raised only on the node, the fix still
> works.


Not sure how the fix works.. since we excluded only the ones offline. So 
unless all online cpu's check in, the code should give you the old behavior.

What does cat /proc/interrupts | grep MCE 

In a system broadcasting, all cpu counts should be the same. Since we didn't 
increment the offline stats, if you were to bring the cpu up, it should be one
less than other cpus... 


Cheers,
Ashok


  parent reply	other threads:[~2015-12-07 22:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-05  0:29 [Patch V2] x86, mce: Ensure offline CPU's don't participate in mce rendezvous process Ashok Raj
2015-12-07 20:00 ` Borislav Petkov
2015-12-07 20:04   ` Luck, Tony
2015-12-07 20:19     ` Borislav Petkov
2015-12-07 22:07       ` Luck, Tony
2015-12-07 22:34         ` Borislav Petkov
2015-12-07 23:26           ` Luck, Tony
2015-12-07 23:46           ` Raj, Ashok [this message]
2015-12-07 23:25             ` Borislav Petkov
2015-12-08  1:41               ` Raj, Ashok
2015-12-08  9:18                 ` Borislav Petkov
2015-12-08 15:59                   ` Luck, Tony
2015-12-08 18:56                     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151207234639.GA81526@otc-brkl-03.jf.intel.com \
    --to=ashok.raj@intel.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).