From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933533AbbLHQaq (ORCPT ); Tue, 8 Dec 2015 11:30:46 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:37432 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933388AbbLHQap (ORCPT ); Tue, 8 Dec 2015 11:30:45 -0500 Date: Tue, 08 Dec 2015 11:30:42 -0500 (EST) Message-Id: <20151208.113042.982813461385384189.davem@davemloft.net> To: rweikusat@mobileactivedefense.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix inverted test in __skb_recv_datagram From: David Miller In-Reply-To: <87io4980c3.fsf@doppelsaurus.mobileactivedefense.com> References: <87vb8925vx.fsf_-_@doppelsaurus.mobileactivedefense.com> <20151207.222827.1680789119862020474.davem@davemloft.net> <87io4980c3.fsf@doppelsaurus.mobileactivedefense.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 08 Dec 2015 08:30:43 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rainer Weikusat Date: Tue, 08 Dec 2015 14:46:36 +0000 > David Miller writes: >> From: Rainer Weikusat >> Date: Mon, 07 Dec 2015 23:30:58 +0000 >> >>> As the kernel generally uses negated error numbers, *err needs to be >>> compared with -EAGAIN (d'oh). >>> >>> Signed-off-by: Rainer Weikusat >>> Fixes: ea3793ee29d3 >> >> Improperly formatted Fixes: tag, you must also include the commit >> header line, in parenthesis and double quotes, after the SHA_ID. >> >> Futhermore this is the wrong SHA_ID. > > https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=ea3793ee29d3 > > displays the commit I was referring to, namely, the one containing this My bad.