From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756873AbbLHP3W (ORCPT ); Tue, 8 Dec 2015 10:29:22 -0500 Received: from mail.kernel.org ([198.145.29.136]:53165 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753942AbbLHP3U (ORCPT ); Tue, 8 Dec 2015 10:29:20 -0500 Date: Tue, 8 Dec 2015 12:29:15 -0300 From: Arnaldo Carvalho de Melo To: Josh Poimboeuf Cc: Jiri Olsa , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] perf tools: Move perf subcommand framework into lib/tools Message-ID: <20151208152915.GI11564@kernel.org> References: <20151206093752.GA4022@gmail.com> <20151206155003.GA11852@krava.brq.redhat.com> <20151206200242.GM11394@treble.redhat.com> <20151207084648.GA19908@krava.brq.redhat.com> <20151208145233.GF11564@kernel.org> <20151208145531.GG11564@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151208145531.GG11564@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Dec 08, 2015 at 11:55:31AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Dec 08, 2015 at 11:52:33AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Dec 07, 2015 at 09:46:48AM +0100, Jiri Olsa escreveu: > > > On Sun, Dec 06, 2015 at 02:02:42PM -0600, Josh Poimboeuf wrote: > > > > I think the problem is that you have a stale version of the > > > > auto-generated file llvm-src-base.c. Looks like "make clean" doesn't > > > > remove it. I'll add a patch to fix it. > > > > FYI I switched back to Arnaldo's perf/core and did 'make clean && make' > > > which passed, then switched back to your change and build failed again > > > Even after his patches, it doesn't work, but I think this time he is not > > taking $(OUTPUT) into account, and as I do use "O=/tmp/build/perf/" it > > fails, trying to fix this... > > Nah, that was me not using O= for the 'make clean' call, after I do > that, it works. > > But its sad everytime we introduce the need to run 'make clean' to > regain a clean build environment :-\ Ok, now trying to run: make -C tools/perf build-test It fails here with: [acme@ssdandy linux]$ cat ./tools/perf/make_clean_all_O cd . && make -f Makefile O=/tmp/tmp.4iuuIJy0Ia DESTDIR=/tmp/tmp.EeBhrZY9H2 clean all CLEAN libtraceevent CLEAN libapi CLEAN libbpf CLEAN config CLEAN feature CLEAN tests find: ‘/tmp/tmp.4iuuIJy0Ia/tests’: No such file or directory make[4]: *** [tests-clean] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [clean] Error 2 [acme@ssdandy linux]$ This is after applying: [acme@ssdandy perf]$ git log --oneline | head -3 dbb37aec117a perf tools: Use -iquote for local include paths e32ac4f249a1 perf tools: Fix 'make clean' a30c99a0beb3 Merge branch 'perf/urgent' into perf/core, to pick up fixes [acme@ssdandy perf]$ ----------------------------------------------------------------------------------------------- [acme@ssdandy linux]$ ls -la /tmp/tmp.EeBhrZY9H2 total 4 drwx------. 2 acme acme 6 Dec 8 12:17 . drwxrwxrwt. 26 root root 4096 Dec 8 12:17 .. [acme@ssdandy linux]$ [acme@ssdandy linux]$ cd tools/perf [acme@ssdandy perf]$ make -f Makefile O=/tmp/tmp.4iuuIJy0Ia DESTDIR=/tmp/tmp.EeBhrZY9H2 clean all CLEAN libtraceevent CLEAN libapi CLEAN libbpf CLEAN config CLEAN feature CLEAN tests find: ‘/tmp/tmp.4iuuIJy0Ia/tests’: No such file or directory make[1]: *** [tests-clean] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [clean] Error 2 [acme@ssdandy perf]$ - Arnaldo