From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756854AbbLHPl6 (ORCPT ); Tue, 8 Dec 2015 10:41:58 -0500 Received: from mail.kernel.org ([198.145.29.136]:54860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755075AbbLHPl5 (ORCPT ); Tue, 8 Dec 2015 10:41:57 -0500 Date: Tue, 8 Dec 2015 12:41:48 -0300 From: Arnaldo Carvalho de Melo To: Josh Poimboeuf Cc: Jiri Olsa , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] perf tools: Move perf subcommand framework into lib/tools Message-ID: <20151208154148.GJ11564@kernel.org> References: <20151206093752.GA4022@gmail.com> <20151206155003.GA11852@krava.brq.redhat.com> <20151206200242.GM11394@treble.redhat.com> <20151207084648.GA19908@krava.brq.redhat.com> <20151208145233.GF11564@kernel.org> <20151208145531.GG11564@kernel.org> <20151208152915.GI11564@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151208152915.GI11564@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Dec 08, 2015 at 12:29:15PM -0300, Arnaldo Carvalho de Melo escreveu: > find: ‘/tmp/tmp.4iuuIJy0Ia/tests’: No such file or directory > make[4]: *** [tests-clean] Error 1 > make[4]: *** Waiting for unfinished jobs.... > make[3]: *** [clean] Error 2 > [acme@ssdandy linux]$ So, to reproduce: [acme@zoo linux]$ rmdir /tmp/foo [acme@zoo linux]$ mkdir /tmp/foo [acme@zoo linux]$ make O=/tmp/foo -C tools/perf clean make: Entering directory '/home/git/linux/tools/perf' CLEAN libtraceevent CLEAN libapi CLEAN config CLEAN libbpf CLEAN feature CLEAN tests find: ‘/tmp/foo/tests’: No such file or directory Makefile.perf:592: recipe for target 'tests-clean' failed make[1]: *** [tests-clean] Error 1 make[1]: *** Waiting for unfinished jobs.... Makefile:75: recipe for target 'clean' failed make: *** [clean] Error 2 make: Leaving directory '/home/git/linux/tools/perf' [acme@zoo linux]$ Then, applying the patch below, it works, Jiri, would this be the best way to solve this? The RM call right after the find works because it uses 'rm -f', I think: o linux]$ patch -p1 < /tmp/a.patch patching file tools/perf/Makefile.perf [acme@zoo linux]$ make O=/tmp/foo -C tools/perf clean make: Entering directory '/home/git/linux/tools/perf' CLEAN libapi CLEAN libbpf CLEAN libtraceevent CLEAN config CLEAN feature CLEAN tests CLEAN core-objs CLEAN core-progs CLEAN core-gen SUBDIR Documentation CLEAN Documentation CLEAN python make: Leaving directory '/home/git/linux/tools/perf' [acme@zoo linux]$ mkdir /tmp/foo/tests/ [acme@zoo linux]$ touch /tmp/foo/tests/.a.cmd [acme@zoo linux]$ make O=/tmp/foo -C tools/perf clean make: Entering directory '/home/git/linux/tools/perf' CLEAN libtraceevent CLEAN libapi CLEAN libbpf CLEAN config CLEAN feature CLEAN tests CLEAN core-objs CLEAN core-progs CLEAN core-gen SUBDIR Documentation CLEAN Documentation CLEAN python make: Leaving directory '/home/git/linux/tools/perf' [acme@zoo linux]$ ls /tmp/foo/tests/ [acme@zoo linux]$ Regards, - Arnaldo diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf index 8b63dbdff197..331a0377da1f 100644 --- a/tools/perf/Makefile.perf +++ b/tools/perf/Makefile.perf @@ -590,7 +590,7 @@ feature-clean: tests-clean: $(call QUIET_CLEAN, tests) - $(Q)find $(OUTPUT)tests -name '*.o' -delete -o -name '\.*.cmd' -delete + $(Q)$(test -d $(OUTPUT)tests && find $(OUTPUT)tests -name '*.o' -delete -o -name '\.*.cmd' -delete) $(Q)$(RM) $(OUTPUT)tests/llvm-src-{base,kbuild,prologue}.c clean: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean config-clean feature-clean tests-clean