From: Mark Brown <broonie@kernel.org>
To: Xiubo Li <lixiubo@cmss.chinamobile.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] regmap: cache: Tidy up the code to suppress style check warnings
Date: Tue, 8 Dec 2015 17:12:35 +0000 [thread overview]
Message-ID: <20151208171235.GV5727@sirena.org.uk> (raw)
In-Reply-To: <1449135113-31892-2-git-send-email-lixiubo@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Thu, Dec 03, 2015 at 05:31:51PM +0800, Xiubo Li wrote:
> There will be some warning like the following when checking new
> patches near this code:
> "WARNING: Missing a blank line after declarations"
> This patch will suppress this warning.
> switch (map->cache_word_size) {
> - case 1: {
> - u8 *cache = base;
> - cache[idx] = val;
> + case 1:
> + ((u8 *)base)[idx] = val;
> break;
> - }
If there's a change to shut checkpatch up I'd rather just add the blank
line it's asking for - the code is the way it is currently to avoid the
casts since they're hard for people to read.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-12-08 17:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 9:31 [PATCH 0/3] regmap: add 64-bit support Xiubo Li
2015-12-03 9:31 ` [PATCH 1/3] regmap: cache: Tidy up the code to suppress style check warnings Xiubo Li
2015-12-08 17:12 ` Mark Brown [this message]
2015-12-09 3:30 ` [PATCH 1/3] regmap: cache: Tidy up the code to suppress stylecheck warnings Xiubo Li
2015-12-03 9:31 ` [PATCH 2/3] regmap: add 64-bit mode support Xiubo Li
2015-12-08 19:11 ` Applied "regmap: add 64-bit mode support" to the regmap tree Mark Brown
2015-12-09 8:45 ` [PATCH 2/3] regmap: add 64-bit mode support Arnd Bergmann
2015-12-09 9:01 ` Xiubo Li
2015-12-03 9:31 ` [PATCH 3/3] regcache: " Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208171235.GV5727@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).