From: "Michael S. Tsirkin" <mst@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: netdev@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Asias He <asias@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] vhost: vsock: select CONFIG_VHOST
Date: Tue, 8 Dec 2015 18:09:44 +0200 [thread overview]
Message-ID: <20151208180529-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <36261336.7BBY96nNaM@wuerfel>
On Tue, Dec 08, 2015 at 04:46:08PM +0100, Arnd Bergmann wrote:
> When building the new vsock code without vhost, we get a build error:
>
> drivers/built-in.o: In function `vhost_vsock_flush':
> :(.text+0x24d29c): undefined reference to `vhost_poll_flush'
>
> This adds an explicit 'select' like we have for the other vhost
> drivers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This will need to be done eventually, so
Acked-by: Michael S. Tsirkin <mst@redhat.com>
but I really think the right thing for now is to revert current vsock
code, or disable building it unconditionally. Stefan, could you please
send a patch like this?
> ---
> drivers/vhost/Kconfig.vsock | 2 ++
> 1 file changed, 2 insertions(+)
>
> The patch causing the problem is currently in net-next, so the fix should be
> applied on top of that.
>
> diff --git a/drivers/vhost/Kconfig.vsock b/drivers/vhost/Kconfig.vsock
> index 3491865d3eb9..bfb9edc4b5d6 100644
> --- a/drivers/vhost/Kconfig.vsock
> +++ b/drivers/vhost/Kconfig.vsock
> @@ -2,6 +2,8 @@ config VHOST_VSOCK
> tristate "vhost virtio-vsock driver"
> depends on VSOCKETS && EVENTFD
> select VIRTIO_VSOCKETS_COMMON
> + select VHOST
> + select VHOST_RING
> default n
> ---help---
> Say M here to enable the vhost-vsock for virtio-vsock guests
> --
> 2.1.0.rc2
>
next prev parent reply other threads:[~2015-12-08 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 15:46 [PATCH] vhost: vsock: select CONFIG_VHOST Arnd Bergmann
2015-12-08 16:09 ` Michael S. Tsirkin [this message]
2015-12-08 17:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208180529-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=asias@redhat.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).