From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063AbbLIU0Z (ORCPT ); Wed, 9 Dec 2015 15:26:25 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:39062 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbbLIU0Y (ORCPT ); Wed, 9 Dec 2015 15:26:24 -0500 Date: Wed, 09 Dec 2015 15:26:22 -0500 (EST) Message-Id: <20151209.152622.589509558160050773.davem@davemloft.net> To: p.fedin@samsung.com Cc: sunil.kovvuri@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sunil.Goutham@caviumnetworks.com, sgoutham@cavium.com Subject: Re: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware From: David Miller In-Reply-To: <00b701d13279$d54d9c80$7fe8d580$@samsung.com> References: <1449661081-15435-2-git-send-email-sunil.kovvuri@gmail.com> <00b701d13279$d54d9c80$7fe8d580$@samsung.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 09 Dec 2015 12:26:23 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Fedin Date: Wed, 09 Dec 2015 15:05:01 +0300 > Hello! > >> -----Original Message----- >> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On Behalf Of Sunil >> Goutham >> Sent: Wednesday, December 09, 2015 2:38 PM >> To: netdev@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; p.fedin@samsung.com; >> Sunil.Goutham@caviumnetworks.com; Sunil Goutham >> Subject: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware >> >> From: Sunil Goutham >> >> This adds support for offloading TCP segmentation to HW in pass-2 >> revision of hardware. Both driver level SW TSO for pass1.x chips >> and HW TSO for pass-2 chip will co-exist. >> >> Signed-off-by: Sunil Goutham >> --- >> drivers/net/ethernet/cavium/thunder/nic.h | 12 ++++++-- >> drivers/net/ethernet/cavium/thunder/nic_main.c | 11 ++----- >> drivers/net/ethernet/cavium/thunder/nicvf_main.c | 15 ++++++++- >> drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 20 ++++++++++--- >> drivers/net/ethernet/cavium/thunder/q_struct.h | 30 ++++++++++--------- >> 5 files changed, 56 insertions(+), 32 deletions(-) >> >> diff --git a/drivers/net/ethernet/cavium/thunder/nic.h >> b/drivers/net/ethernet/cavium/thunder/nic.h >> index 39ca674..02571f4 100644 >> --- a/drivers/net/ethernet/cavium/thunder/nic.h >> +++ b/drivers/net/ethernet/cavium/thunder/nic.h >> @@ -262,9 +262,10 @@ struct nicvf { >> struct pci_dev *pdev; >> u8 vf_id; >> u8 node; >> - u8 tns_mode:1; >> - u8 sqs_mode:1; >> - u8 loopback_supported:1; >> + bool tns_mode:1; >> + bool sqs_mode:1; > > These little refactors are creeping in your code without even being mentioned in the commit message, this is not good practice > IMHO. Additionally, may be turn these two flags into something like: Also I disagree completely with boolean bitfields. Just use plain 'bool' and let the compiler decide how to lay it out.