From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264AbbLICjx (ORCPT ); Tue, 8 Dec 2015 21:39:53 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:32964 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753234AbbLICju (ORCPT ); Tue, 8 Dec 2015 21:39:50 -0500 Date: Wed, 9 Dec 2015 08:09:46 +0530 From: Viresh Kumar To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, maxime.coquelin@st.com, linux-pm@vger.kernel.org, rjw@rjwysocki.net, devicetree@vger.kernel.org, ajitpal.singh@st.com Subject: Re: [PATCH v5 08/11] ARM: STi: Register CPUFreq device Message-ID: <20151209023946.GU3692@ubuntu> References: <1449585124-15596-1-git-send-email-lee.jones@linaro.org> <1449585124-15596-9-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449585124-15596-9-git-send-email-lee.jones@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-12-15, 14:32, Lee Jones wrote: > +/** > + * SMP Operations > + */ Why do you need a documentation style comment here? > static void write_pen_release(int val) > { > pen_release = val; > @@ -161,3 +166,11 @@ struct smp_operations __initdata sti_smp_ops = { > .smp_secondary_init = sti_secondary_init, > .smp_boot_secondary = sti_boot_secondary, > }; > + > +/** > + * CPUFreq Registration > + */ Here too. > +void init_cpufreq(void) > +{ > + platform_device_register_simple("sti-cpufreq", -1, NULL, 0); > +} I don't think you need this, as you can do all the stuff you want from the module_init() function in the driver. You just have to make sure that your driver is only compilable and workable on the right STi platform. -- viresh