From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753961AbbLIWph (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 17:45:37 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:33095 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750904AbbLIWpg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 17:45:36 -0500
Date: Wed, 9 Dec 2015 14:45:35 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Andy Shevchenko <andy.shevchenko@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] hexdump: Add ability to do endian conversions in
 print_hex_dump functions
Message-Id: <20151209144535.1e8f4ed8a8d5d070d574d59f@linux-foundation.org>
In-Reply-To: <1449699396.25389.76.camel@perches.com>
References: <CAL_JsqJ0oftptSxyAcGOnQ3XA9v55B2n=8DiWBcErcLKgfsppg@mail.gmail.com>
	<bc67748274ffac118e61374200256e1ae17acf19.1449697255.git.joe@perches.com>
	<20151209140937.6f246a47e19068e95780fc84@linux-foundation.org>
	<1449699396.25389.76.camel@perches.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 09 Dec 2015 14:16:36 -0800 Joe Perches <joe@perches.com> wrote:

> On Wed, 2015-12-09 at 14:09 -0800, Andrew Morton wrote:
> > On Wed,____9 Dec 2015 13:59:30 -0800 Joe Perches <joe@perches.com> wrote:
> > 
> > > There are use cases for dumping buffers with specific endian types
> > > for 2, 4, and 8 byte variables in arrays.
> > > 
> > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such.
> > > 
> > > Rename groupsize to groupflags in the functions and add documentation
> > > to the kernel-doc to describe the use of the DUMP_TYPE_ enum.
> > 
> > What are these use cases?
> 
> Buffers that contain LE or BE arrays that want
> to be emitted by print_hex_dump.

Make that "where are".

> > Will patches be forthcoming to convert them?
> 
> Sure, after a settling period for Masahiro's patch
> to be applied upstream.
> 
> https://lkml.org/lkml/2015/12/8/480

One single callsite under #ifdef DEBUG?  Doesn't seem to warrant adding
code and complexity to core library functions.