From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCHSET 0/7] perf tools: Remove browser dependency from usage_with_options()
Date: Thu, 10 Dec 2015 15:53:50 -0300 [thread overview]
Message-ID: <20151210185350.GG17996@kernel.org> (raw)
In-Reply-To: <20151210151021.GD29872@treble.redhat.com>
Em Thu, Dec 10, 2015 at 09:10:21AM -0600, Josh Poimboeuf escreveu:
> On Thu, Dec 10, 2015 at 12:00:52PM +0900, Namhyung Kim wrote:
> > Hello,
> >
> > This patchset removes the UI browser dependency (specifically
> > exit_browser function) from option parser code. It'll help to
> > separate out the common code into a library.
> >
> > Now existing users of usage_with_options() were converted to call it
> > before setup_browser(). I think future users can notice the
> > difference when they test their code and will call it properly.
> >
> > It's available on 'perf/option-dependency-v1' branch on my tree
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
So, applied all except for the top one, that I rewrote as reported,
pushed to perf/core, the replaced patch is this one:
https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=f8a5c0b24b8b1e77a0812b0c8251db0afc0524b7
> >
> > Namhyung Kim (7):
> > perf annotate: Check argument before calling setup_browser()
> > perf annotate: Delay UI browser setup after initialization is done
> > perf kvm: Remove invocation of setup/exit_browser()
> > perf report: Check argument before calling setup_browser()
> > perf top: Delay UI browser setup after initialization is done
> > perf tools: Free strlist on error path
> > perf tools: Get rid of exit_browser() from usage_with_options()
> >
> > tools/perf/builtin-annotate.c | 33 ++++++++++++++++-----------------
> > tools/perf/builtin-kvm.c | 3 ---
> > tools/perf/builtin-report.c | 21 ++++++++++-----------
> > tools/perf/builtin-top.c | 14 +++++++-------
> > tools/perf/util/parse-options.c | 3 ---
> > tools/perf/util/thread_map.c | 1 +
> > 6 files changed, 34 insertions(+), 41 deletions(-)
>
> Thanks a lot Namhyung!
>
> For the series,
>
> Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
> --
> Josh
prev parent reply other threads:[~2015-12-10 18:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 3:00 [PATCHSET 0/7] perf tools: Remove browser dependency from usage_with_options() Namhyung Kim
2015-12-10 3:00 ` [PATCH 1/7] perf annotate: Check argument before calling setup_browser() Namhyung Kim
2015-12-14 8:12 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 2/7] perf annotate: Delay UI browser setup after initialization is done Namhyung Kim
2015-12-14 8:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 3/7] perf kvm: Remove invocation of setup/exit_browser() Namhyung Kim
2015-12-14 8:13 ` [tip:perf/core] perf kvm: Remove invocation of setup/exit_browser () tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 4/7] perf report: Check argument before calling setup_browser() Namhyung Kim
2015-12-14 8:13 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 5/7] perf top: Delay UI browser setup after initialization is done Namhyung Kim
2015-12-10 17:43 ` Arnaldo Carvalho de Melo
2015-12-10 17:52 ` Arnaldo Carvalho de Melo
2015-12-10 18:06 ` Arnaldo Carvalho de Melo
2015-12-10 3:00 ` [PATCH 6/7] perf tools: Free strlist on error path Namhyung Kim
2015-12-14 8:14 ` [tip:perf/core] perf thread_map: Free strlist on constructor " tip-bot for Namhyung Kim
2015-12-10 3:00 ` [PATCH 7/7] perf tools: Get rid of exit_browser() from usage_with_options() Namhyung Kim
2015-12-14 8:14 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-12-10 15:10 ` [PATCHSET 0/7] perf tools: Remove browser dependency " Josh Poimboeuf
2015-12-10 18:53 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210185350.GG17996@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).