From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: netdev@vger.kernel.org, w-kwok2@ti.com, m-karicheri2@ti.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] netcp: add more __le32 annotations
Date: Fri, 11 Dec 2015 19:35:03 -0500 (EST) [thread overview]
Message-ID: <20151211.193503.312733505035879098.davem@davemloft.net> (raw)
In-Reply-To: <6435706.peaM34LhnV@wuerfel>
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 08 Dec 2015 16:32:59 +0100
> The handling of epib and psdata remains a bit unclear in the driver,
> as we access the same fields both as CPU-endian and through DMA
> from the device.
>
> Sparse warns about this:
> ti/netcp_core.c:1147:21: warning: incorrect type in assignment (different base types)
> ti/netcp_core.c:1147:21: expected unsigned int [usertype] *[assigned] epib
> ti/netcp_core.c:1147:21: got restricted __le32 *<noident>
>
> This uses __le32 types in a few places and uses __force where the code
> looks fishy. The previous patch should really have produced the correct
> behavior, but this second patch is needed to shut up the warnings about
> it. Ideally it would be slightly rewritten to not need those casts,
> but I don't dare do that without access to the hardware for proper
> testing.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to net-next.
next prev parent reply other threads:[~2015-12-12 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 15:32 [PATCH 1/2] netcp: try to reduce type confusion in descriptors Arnd Bergmann
2015-12-08 15:32 ` [PATCH 2/2] netcp: add more __le32 annotations Arnd Bergmann
2015-12-12 0:35 ` David Miller [this message]
2015-12-12 0:34 ` [PATCH 1/2] netcp: try to reduce type confusion in descriptors David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211.193503.312733505035879098.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).