From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752931AbbLKCzu (ORCPT ); Thu, 10 Dec 2015 21:55:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37698 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbbLKCzt (ORCPT ); Thu, 10 Dec 2015 21:55:49 -0500 Date: Fri, 11 Dec 2015 10:55:43 +0800 From: Baoquan He To: Geliang Tang Cc: Andrew Morton , Dave Young , Vivek Goyal , linux-kernel@vger.kernel.org Subject: Re: [PATCH] kexec: use list_for_each_entry_safe in kimage_free_page_list Message-ID: <20151211025543.GA2544@x1.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/15 at 12:08am, Geliang Tang wrote: > Use list_for_each_entry_safe() instead of list_for_each_safe() to > simplify the code. > > Signed-off-by: Geliang Tang > --- > kernel/kexec_core.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c > index 11b64a6..f3951c7 100644 > --- a/kernel/kexec_core.c > +++ b/kernel/kexec_core.c > @@ -310,12 +310,9 @@ static void kimage_free_pages(struct page *page) > > void kimage_free_page_list(struct list_head *list) > { > - struct list_head *pos, *next; > + struct page *page, *next; > > - list_for_each_safe(pos, next, list) { > - struct page *page; > - > - page = list_entry(pos, struct page, lru); > + list_for_each_entry_safe(page, next, list, lru) { A small improvement, seems better. Ack it. Please also send kexec mailing list if you have kexec related patchs so that more people are attracted: kexec@lists.infradead.org Acked-by: Baoquan He Thanks Baoquan