From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752727AbbLMUbV (ORCPT ); Sun, 13 Dec 2015 15:31:21 -0500 Received: from know-smtprelay-omc-6.server.virginmedia.net ([80.0.253.70]:44983 "EHLO know-smtprelay-omc-6.server.virginmedia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626AbbLMUbU (ORCPT ); Sun, 13 Dec 2015 15:31:20 -0500 X-Originating-IP: [82.27.143.36] X-Spam: 0 X-Authority: v=2.1 cv=P+nH/X0u c=1 sm=1 tr=0 a=sI0VlXMVYIpMuXrauH8AmA==:117 a=sI0VlXMVYIpMuXrauH8AmA==:17 a=NLZqzBF-AAAA:8 a=IkcTkHD0fZMA:10 a=wUQvQvOEmiQA:10 a=O8xXmTb3Igc69pC9LCQA:9 a=QEXdDO2ut3YA:10 Date: Sun, 13 Dec 2015 20:31:17 +0000 From: Ken Moffat To: Frederik Cc: Nicolai Stange , Greg KH , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com, linux-kernel@i4.cs.fau.de, lukas.braun@fau.de Subject: Re: [PATCH 0/9] Fix checkpatch errors Message-ID: <20151213203117.GA1012@milliways> References: <1449830170-15096-1-git-send-email-frederik.voelkel@fau.de> <20151213070622.GA13621@kroah.com> <20151213174429.GB11792@faumail.uni-erlangen.de> <87poyamczv.fsf@gmail.com> <20151213182604.GC11792@faumail.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett Content-Transfer-Encoding: 8bit In-Reply-To: <20151213182604.GC11792@faumail.uni-erlangen.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 13, 2015 at 07:26:04PM +0100, Frederik wrote: > On Sun, 13. Dec 19:15, Nicolai Stange wrote: > > Frederik writes: > > > > W/o your series applied (so line numbering might be slightly > > different), checkpatch.pl says: > > > > ERROR: trailing whitespace > > #270: FILE: -:270: > > +^I * This do { } while() loop will get ALL chars out of Rx FIFO $ > > > > AFAICS, your patch [7/9] ("drivers: tty: 68328serial.c: remove trailing > > whitespaces") doesn't fix this one. > > > > In good old regexp tradition, the '$' sign denotes the end of line. So, > > there is a single space after "FIFO" and before the end of line. > > > > If you happen to be Emacs users, consider trying out whitespace-mode. > > If not, try to find another way to make your editor visualize whitespace > > somehow. > > Oh right I see. We will fix that and resend. > > Thank you! If you are using vim, I have the following in my .vimrc. It was originally posted here many years ago. Seems to work on all my x86 boxes, but AFAIR it didn't work on a ppc, so might not work on other architectures. "for redundant whitespace, from Jeremy Kerr via Olof Johanson highlight RedundantWhitespace ctermbg=red guibg=red match RedundantWhitespace /\s\+$\| \+\ze\t/ HTH ĸen -- This email was written using 100% recycled letters.