From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932392AbbLNKI5 (ORCPT ); Mon, 14 Dec 2015 05:08:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33229 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932247AbbLNKIy (ORCPT ); Mon, 14 Dec 2015 05:08:54 -0500 Date: Mon, 14 Dec 2015 11:08:51 +0100 From: Jiri Olsa To: Josh Poimboeuf Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Namhyung Kim Subject: Re: [PATCH v3 02/17] tools build: Fix feature Makefile dependencies for 'O=' Message-ID: <20151214100851.GD27640@krava.brq.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 13, 2015 at 10:18:02PM -0600, Josh Poimboeuf wrote: > Signed-off-by: Josh Poimboeuf > --- > tools/build/Makefile.feature | 2 +- > tools/build/feature/Makefile | 95 ++++++++++++++++++++++---------------------- > 2 files changed, 49 insertions(+), 48 deletions(-) > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > index b8c31ec..6c0519d 100644 > --- a/tools/build/Makefile.feature > +++ b/tools/build/Makefile.feature > @@ -7,7 +7,7 @@ endif > > feature_check = $(eval $(feature_check_code)) > define feature_check_code > - feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS) $(FEATURE_CHECK_CFLAGS-$(1))" LDFLAGS="$(LDFLAGS) $(FEATURE_CHECK_LDFLAGS-$(1))" -C $(feature_dir) test-$1.bin >/dev/null 2>/dev/null && echo 1 || echo 0) > + feature-$(1) := $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS) $(FEATURE_CHECK_CFLAGS-$(1))" LDFLAGS="$(LDFLAGS) $(FEATURE_CHECK_LDFLAGS-$(1))" -C $(feature_dir) $(OUTPUT_FEATURES)test-$1.bin >/dev/null 2>/dev/null && echo 1 || echo 0) > endef > > feature_set = $(eval $(feature_set_code)) > diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile > index cea04ce9..8fec49d 100644 > --- a/tools/build/feature/Makefile > +++ b/tools/build/feature/Makefile > @@ -1,4 +1,3 @@ > - > FILES= \ > test-all.bin \ > test-backtrace.bin \ > @@ -38,38 +37,40 @@ FILES= \ > test-bpf.bin \ > test-get_cpuid.bin > > +OUTPUT_FILES = $(addprefix $(OUTPUT),$(FILES)) seems there's no need to introduce new variable, you could use FILES: FILES := $(addprefix $(OUTPUT),$(FILES)) jirka