From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932340AbbLNKKs (ORCPT <rfc822;w@1wt.eu>);
	Mon, 14 Dec 2015 05:10:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55609 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932244AbbLNKKq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 14 Dec 2015 05:10:46 -0500
Date: Mon, 14 Dec 2015 11:10:43 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v3 03/17] perf test: Add Build file to dependencies for
 llvm-src-*.c
Message-ID: <20151214101043.GE27640@krava.brq.redhat.com>
References: <cover.1449965119.git.jpoimboe@redhat.com>
 <9b9886c295750dc83cbbb29a665d280f9c5e8b3e.1449965119.git.jpoimboe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9b9886c295750dc83cbbb29a665d280f9c5e8b3e.1449965119.git.jpoimboe@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Dec 13, 2015 at 10:18:03PM -0600, Josh Poimboeuf wrote:
> Because the Build file writes source code to the generated llvm-src-*.c
> files, it should be listed as one of the dependencies, so that any
> future changes to the code being echoed won't require a 'make clean'.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
>  tools/perf/tests/Build | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
> index 0ff8a97..f23fb7e 100644
> --- a/tools/perf/tests/Build
> +++ b/tools/perf/tests/Build
> @@ -35,21 +35,21 @@ perf-y += llvm.o llvm-src-base.o llvm-src-kbuild.o llvm-src-prologue.o
>  perf-y += bpf.o
>  perf-y += topology.o
>  
> -$(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c
> +$(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build
>  	$(call rule_mkdir)
>  	$(Q)echo '#include <tests/llvm.h>' > $@
>  	$(Q)echo 'const char test_llvm__bpf_base_prog[] =' >> $@
>  	$(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
>  	$(Q)echo ';' >> $@
>  
> -$(OUTPUT)tests/llvm-src-kbuild.c: tests/bpf-script-test-kbuild.c
> +$(OUTPUT)tests/llvm-src-kbuild.c: tests/bpf-script-test-kbuild.c tests/Build
>  	$(call rule_mkdir)
>  	$(Q)echo '#include <tests/llvm.h>' > $@
>  	$(Q)echo 'const char test_llvm__bpf_test_kbuild_prog[] =' >> $@
>  	$(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
>  	$(Q)echo ';' >> $@
>  
> -$(OUTPUT)tests/llvm-src-prologue.c: tests/bpf-script-test-prologue.c
> +$(OUTPUT)tests/llvm-src-prologue.c: tests/bpf-script-test-prologue.c tests/Build
>  	$(call rule_mkdir)
>  	$(Q)echo '#include <tests/llvm.h>' > $@
>  	$(Q)echo 'const char test_llvm__bpf_test_prologue_prog[] =' >> $@
> -- 
> 2.4.3
>