From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932306AbbLNKqM (ORCPT ); Mon, 14 Dec 2015 05:46:12 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:38014 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932200AbbLNKqK (ORCPT ); Mon, 14 Dec 2015 05:46:10 -0500 Date: Mon, 14 Dec 2015 10:46:07 +0000 From: Matt Fleming To: Markus Trippelsdorf Cc: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH] Fix misleading indentation issues in perf Message-ID: <20151214104607.GA2571@codeblueprint.co.uk> References: <20151212180702.GA753@x4> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151212180702.GA753@x4> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Dec, at 07:07:02PM, Markus Trippelsdorf wrote: > perf doesn't build with gcc-6 because of several misleading-indentation > warnings, e.g.: > > arch/x86/tests/intel-cqm.c: In function ‘spawn’: > arch/x86/tests/intel-cqm.c:21:3: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation] > sleep(5); > ^~~~~ > > arch/x86/tests/intel-cqm.c:20:2: note: ...this ‘while’ clause, but it is not > while(1); > ^~~~~ > > Signed-off-by: Markus Trippelsdorf > > diff --git a/tools/perf/arch/x86/tests/intel-cqm.c b/tools/perf/arch/x86/tests/intel-cqm.c > index d28c1b6a3b54..fa5d17af88b7 100644 > --- a/tools/perf/arch/x86/tests/intel-cqm.c > +++ b/tools/perf/arch/x86/tests/intel-cqm.c > @@ -17,7 +17,7 @@ static pid_t spawn(void) > if (pid) > return pid; > > - while(1); > + while(1) > sleep(5); > return 0; > } Whoops. Good catch. Reviewed-by: Matt Fleming