From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752345AbbLNPMz (ORCPT ); Mon, 14 Dec 2015 10:12:55 -0500 Received: from mail.kernel.org ([198.145.29.136]:37666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751700AbbLNPMy (ORCPT ); Mon, 14 Dec 2015 10:12:54 -0500 Date: Mon, 14 Dec 2015 12:12:49 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Andi Kleen , jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools: Disable branch flags/cycles for --callgraph lbr Message-ID: <20151214151249.GG6843@kernel.org> References: <1449879144-29074-1-git-send-email-andi@firstfloor.org> <20151214095538.GB27640@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151214095538.GB27640@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Dec 14, 2015 at 10:55:38AM +0100, Jiri Olsa escreveu: > On Fri, Dec 11, 2015 at 04:12:24PM -0800, Andi Kleen wrote: > > From: Andi Kleen > > > > [The kernel patch needed for this is in tip now > > (b16a5b52eb9 perf/x86: Add option to disable ...) > > So this user tools patch to make use of it should be merged now] > > > > Automatically disable collecting branch flags and cycles with > > --call-graph lbr. This allows avoiding a bunch of extra MSR > > reads in the PMI on Skylake. > > > > When the kernel doesn't support the new flags they are automatically > > cleared in the fallback code. > > > > v2: Switch to use branch_sample_type instead of sample_type. > > Adjust description. > > Fix the fallback logic. > > Signed-off-by: Andi Kleen > > Acked-by: Jiri Olsa Thanks, applied to perf/core. - Arnaldo