From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752071AbbLQB1R (ORCPT ); Wed, 16 Dec 2015 20:27:17 -0500 Received: from mail.kernel.org ([198.145.29.136]:37568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbbLQB1Q (ORCPT ); Wed, 16 Dec 2015 20:27:16 -0500 Date: Wed, 16 Dec 2015 22:27:11 -0300 From: Arnaldo Carvalho de Melo To: Josh Poimboeuf Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH v4 7/9] perf: Finalize subcmd independence Message-ID: <20151217012711.GG19926@kernel.org> References: <6e12946f0f26ce4d543d34db68d9dae3c8551cb9.1450193761.git.jpoimboe@redhat.com> <20151217005741.GF19926@kernel.org> <20151217010953.GA26149@treble.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151217010953.GA26149@treble.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Dec 16, 2015 at 07:09:53PM -0600, Josh Poimboeuf escreveu: > On Wed, Dec 16, 2015 at 09:57:41PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Dec 15, 2015 at 09:39:38AM -0600, Josh Poimboeuf escreveu: > > > For the files that will be moved to the subcmd library, remove all their > > > perf-specific includes and duplicate any needed functionality. > > > > Breaks rhel6.7 building: > > > > > > > > +typedef uint64_t u64; > > > + > > > > > > [acme@sandy linux]$ cat /etc/redhat-release > > Red Hat Enterprise Linux Server release 6.7 (Santiago) > > > > CC /tmp/build/perf/parse-options.o > > parse-options.c:15: error: redefinition of typedef ‘u64’ > > /home/acme/git/linux/tools/include/linux/types.h:28: note: previous > > declaration of ‘u64’ was here > > mv: cannot stat `/tmp/build/perf/.parse-options.o.tmp': No such file or > > directory > > make[3]: *** [/tmp/build/perf/parse-options.o] Error 1 > > make[2]: *** [/tmp/build/perf/libsubcmd-in.o] Error 2 > > make[1]: *** [/tmp/build/perf/libsubcmd.a] Error 2 > > make[1]: *** Waiting for unfinished jobs.... > > MKDIR /tmp/build/perf/util/ > > Does this fix it? Yes, and it continues to build on fedora 21. - Arnaldo > ---8<--- > > diff --git a/tools/lib/subcmd/parse-options.c b/tools/lib/subcmd/parse-options.c > index f424027..981bb44 100644 > --- a/tools/lib/subcmd/parse-options.c > +++ b/tools/lib/subcmd/parse-options.c > @@ -1,4 +1,5 @@ > #include > +#include > #include > #include > #include > @@ -12,8 +13,6 @@ > #define OPT_SHORT 1 > #define OPT_UNSET 2 > > -typedef uint64_t u64; > - > char *error_buf; > > static int opterror(const struct option *opt, const char *reason, int flags)