From: Andreas Werner <andreas.werner@men.de>
To: Jean Delvare <jdelvare@suse.de>
Cc: Andreas Werner <andreas.werner@men.de>,
Guenter Roeck <linux@roeck-us.net>, <wni@nvidia.com>,
<lm-sensors@lm-sensors.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] LM90 driver and ti tmp461 detection
Date: Thu, 17 Dec 2015 12:54:20 +0100 [thread overview]
Message-ID: <20151217115420.GB2349@awelinux> (raw)
In-Reply-To: <20151217124808.63f8f54f@endymion.delvare>
On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote:
> Hi Andreas,
>
> On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> > here is the register dump of the tmp461.
>
> Thanks.
>
> > It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> > Also the magic "ID Register" offset 0xff is 0x00 for both devices.
>
> I would use register 0x16, which doesn't exist but reads 0x00 on the
> TMP451. It could in theory also read 0x00 on the TMP461 but only if
> both channels are disabled, which makes little sense. More likely at
> least one channel will be enabled so you'll have value 0x01-0x03 if
> this is a TMP461.
>
Yes you are right. Both channels are enabled during POR, so the chance
to have a 0x00 as in the TMP451 will be very low.
> --
> Jean Delvare
> SUSE L3 Support
next prev parent reply other threads:[~2015-12-17 11:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 12:08 LM90 driver and ti tmp461 detection Andreas Werner
2015-12-10 16:41 ` Guenter Roeck
2015-12-10 17:12 ` Andreas Werner
2015-12-10 17:43 ` Guenter Roeck
2015-12-10 18:03 ` Andreas Werner
2015-12-10 17:49 ` Guenter Roeck
2015-12-10 18:09 ` Andreas Werner
2015-12-12 10:08 ` [lm-sensors] " Jean Delvare
2015-12-15 15:11 ` Andreas Werner
2015-12-17 11:48 ` Jean Delvare
2015-12-17 11:54 ` Andreas Werner [this message]
2015-12-17 14:57 ` Guenter Roeck
2015-12-18 8:18 ` Andreas Werner
2015-12-12 11:42 Andreas Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217115420.GB2349@awelinux \
--to=andreas.werner@men.de \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).