From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753438AbbLQLsN (ORCPT ); Thu, 17 Dec 2015 06:48:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:42269 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754AbbLQLsM (ORCPT ); Thu, 17 Dec 2015 06:48:12 -0500 Date: Thu, 17 Dec 2015 12:48:08 +0100 From: Jean Delvare To: Andreas Werner Cc: Guenter Roeck , , , Subject: Re: [lm-sensors] LM90 driver and ti tmp461 detection Message-ID: <20151217124808.63f8f54f@endymion.delvare> In-Reply-To: <20151215151123.GA2349@awelinux> References: <20151210120856.GA27765@awelinux> <5669AB55.5030309@roeck-us.net> <20151210171231.GA28022@awelinux> <20151212110842.10e7693e@endymion.delvare> <20151215151123.GA2349@awelinux> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas, On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote: > here is the register dump of the tmp461. Thanks. > It seemse that we really cannot detect if it is a tmp461 or a tmp451. > Also the magic "ID Register" offset 0xff is 0x00 for both devices. I would use register 0x16, which doesn't exist but reads 0x00 on the TMP451. It could in theory also read 0x00 on the TMP461 but only if both channels are disabled, which makes little sense. More likely at least one channel will be enabled so you'll have value 0x01-0x03 if this is a TMP461. -- Jean Delvare SUSE L3 Support