From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966569AbbLQO54 (ORCPT ); Thu, 17 Dec 2015 09:57:56 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:33166 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753438AbbLQO5z (ORCPT ); Thu, 17 Dec 2015 09:57:55 -0500 Date: Thu, 17 Dec 2015 06:57:51 -0800 From: Guenter Roeck To: Jean Delvare Cc: Andreas Werner , wni@nvidia.com, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [lm-sensors] LM90 driver and ti tmp461 detection Message-ID: <20151217145751.GA21030@roeck-us.net> References: <20151210120856.GA27765@awelinux> <5669AB55.5030309@roeck-us.net> <20151210171231.GA28022@awelinux> <20151212110842.10e7693e@endymion.delvare> <20151215151123.GA2349@awelinux> <20151217124808.63f8f54f@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151217124808.63f8f54f@endymion.delvare> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote: > Hi Andreas, > > On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote: > > here is the register dump of the tmp461. > > Thanks. > > > It seemse that we really cannot detect if it is a tmp461 or a tmp451. > > Also the magic "ID Register" offset 0xff is 0x00 for both devices. > > I would use register 0x16, which doesn't exist but reads 0x00 on the > TMP451. It could in theory also read 0x00 on the TMP461 but only if > both channels are disabled, which makes little sense. More likely at > least one channel will be enabled so you'll have value 0x01-0x03 if > this is a TMP461. > Excellent idea! Guenter