From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754864AbbLQTXg (ORCPT ); Thu, 17 Dec 2015 14:23:36 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34035 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752826AbbLQTXe (ORCPT ); Thu, 17 Dec 2015 14:23:34 -0500 Date: Thu, 17 Dec 2015 11:23:31 -0800 From: Eduardo Valentin To: Daniel Kurtz Cc: Sascha Hauer , linux-pm@vger.kernel.org, Zhang Rui , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org, Sasha Hauer , Matthias Brugger , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller Message-ID: <20151217192329.GA7999@localhost.localdomain> References: <1448883753-19068-1-git-send-email-s.hauer@pengutronix.de> <1448883753-19068-2-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2015 at 07:23:22PM +0800, Daniel Kurtz wrote: > On Mon, Nov 30, 2015 at 7:42 PM, Sascha Hauer wrote: > > This adds the device tree binding documentation for the mediatek thermal > > controller found on Mediatek MT8173 and other SoCs. > > > > Signed-off-by: Sascha Hauer > > Reviewed-by: Daniel Kurtz > > Acked-by: Rob Herring > > --- > > .../bindings/thermal/mediatek-thermal.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > new file mode 100644 > > index 0000000..81f9a51 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > > @@ -0,0 +1,43 @@ > > +* Mediatek Thermal > > + > > +This describes the device tree binding for the Mediatek thermal controller > > +which measures the on-SoC temperatures. This device does not have its own ADC, > > +instead it directly controls the AUXADC via AHB bus accesses. For this reason > > +this device needs phandles to the AUXADC. Also it controls a mux in the > > +apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS > > +is also needed. > > + > > +Required properties: > > +- compatible: "mediatek,mt8173-thermal" > > +- reg: Address range of the thermal controller > > +- interrupts: IRQ for the thermal controller > > +- clocks, clock-names: Clocks needed for the thermal controller. required > > + clocks are: > > + "therm": Main clock needed for register access > > + "auxadc": The AUXADC clock > > +- resets: Reference to the reset controller controlling the thermal controller. > > +- mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses > > +- mediatek,apmixedsys: A phandle to the APMIXEDSYS controller. > > +- #thermal-sensor-cells : Should be 0. See ./thermal.txt for a description. > > + > > +Optional properties: > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If > > + unspecified default values shall be used. > > +- nvmem-cell-names: Should be "calibration-data" > > + > > +Example: > > + > > + thermal: thermal@1100b000 { > > + #thermal-sensor-cells = <1>; > > Tiny nit: this should now be: > > #thermal-sensor-cells = <0>; This is actually not so tiny'shy. Why does this driver masks out all sensors available? Why don't we expose all of them and use id property to expose and identify each of them?