From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751755AbbLRFmJ (ORCPT ); Fri, 18 Dec 2015 00:42:09 -0500 Received: from mga04.intel.com ([192.55.52.120]:65124 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbbLRFmH (ORCPT ); Fri, 18 Dec 2015 00:42:07 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,444,1444719600"; d="scan'208";a="874024627" Date: Fri, 18 Dec 2015 11:15:20 +0530 From: Vinod Koul To: Damien Horsley Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Williams , James Hartley Subject: Re: [PATCH V2] dmaengine: mdc: Correct terminate_all handling Message-ID: <20151218054520.GU1854@localhost> References: <1449760043-6292-1-git-send-email-Damien.Horsley@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449760043-6292-1-git-send-email-Damien.Horsley@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2015 at 03:07:23PM +0000, Damien Horsley wrote: > From: "Damien.Horsley" > > Use of the CANCEL bit in mdc_terminate_all creates an > additional 'command done' to appear in the registers (in > addition to an interrupt). > > In addition, there is a potential race between > mdc_terminate_all and the irq handler if a transfer > completes at the same time as the terminate all (presently > this results in an inappropriate warning). > > To handle these issues, any outstanding 'command done' > events are cleared during mdc_terminate_all and the irq > handler takes no action when there are no new 'command done' > events. Applied, thanks -- ~Vinod