From: Brian Norris <computersforpeace@gmail.com>
To: Yao Yuan <yao.yuan@freescale.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
Xu Han <han.xu@freescale.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support
Date: Fri, 18 Dec 2015 14:55:08 -0800 [thread overview]
Message-ID: <20151218225508.GT10460@google.com> (raw)
In-Reply-To: <BLUPR03MB134C01F17B8F52849C4CFD783E10@BLUPR03MB134.namprd03.prod.outlook.com>
On Fri, Dec 18, 2015 at 09:12:13AM +0000, Yao Yuan wrote:
> Hi Woodhouse, Norris,
>
> Do you have any comments for this patch?
No, it looks fine. But the driver maintainer (Han) already asked you for
DT binding documentation already. This is a requirement before I can
merge your patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
> Thanks for your review.
>
> Best Regards,
> Yuan Yao
>
> > -----Original Message-----
> > From: Han Xu [mailto:han.xu@freescale.com]
> > > + q->big_endian = of_property_read_bool(np, "big-endian");
> >
> > I am fine with this patch, but need document the new property with another
> > patch
^^^ See here
Brian
prev parent reply other threads:[~2015-12-18 22:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 9:13 [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support Yuan Yao
2015-11-25 19:09 ` Han Xu
2015-12-18 9:12 ` Yao Yuan
2015-12-18 22:55 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218225508.GT10460@google.com \
--to=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=han.xu@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).