From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933421AbbLTLqX (ORCPT ); Sun, 20 Dec 2015 06:46:23 -0500 Received: from down.free-electrons.com ([37.187.137.238]:52282 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932274AbbLTLqE (ORCPT ); Sun, 20 Dec 2015 06:46:04 -0500 Date: Sun, 20 Dec 2015 12:46:02 +0100 From: Alexandre Belloni To: Juergen Borleis Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 3/3] RTC/PCF85063: fix time/date setting Message-ID: <20151220114602.GE3541@piout.net> References: <1449496174-7813-1-git-send-email-jbe@pengutronix.de> <1449496174-7813-4-git-send-email-jbe@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449496174-7813-4-git-send-email-jbe@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12/2015 at 14:49:34 +0100, Juergen Borleis wrote : > When setting a new time/date the RTC's clock must be stopped first, in > order to write the time/date registers in an atomic manner. > So, this change stops the clock first and then writes the time/date > registers and the clock control register (to re-enable the clock) in one > turn. > I'd have the same comment for that patch. Using i2c_smbus_write_byte_data and i2c_smbus_write_block_data would make the code clearer and also more robust because it takes care of retransmissions for example. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com