From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752975AbbL0MwP (ORCPT ); Sun, 27 Dec 2015 07:52:15 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36777 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbbL0MwM (ORCPT ); Sun, 27 Dec 2015 07:52:12 -0500 Date: Sun, 27 Dec 2015 14:52:02 +0200 From: Leon Romanovsky To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, Doug Ledford , Hal Rosenstock , Or Gerlitz , Roi Dayan , Sagi Grimberg , Sean Hefty , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations Message-ID: <20151227125202.GG8501@leon.nu> Reply-To: leon@leon.nu Mail-Followup-To: SF Markus Elfring , linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, Doug Ledford , Hal Rosenstock , Or Gerlitz , Roi Dayan , Sagi Grimberg , Sean Hefty , LKML , kernel-janitors@vger.kernel.org, Julia Lawall References: <566ABCD9.1060404@users.sourceforge.net> <567FDB4E.2040000@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <567FDB4E.2040000@users.sourceforge.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 27, 2015 at 01:36:30PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 27 Dec 2015 13:12:10 +0100 > Subject: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations > > I suggest to return directly instead of using the jump label "err" > in two functions (which are working without clean-up there). > > Markus Elfring (2): > One jump label less in iser_reg_sig_mr() > One jump label less in isert_reg_sig_mr() Looks good, Reviewed-by: Leon Romanovsky > > drivers/infiniband/ulp/iser/iser_memory.c | 5 ++--- > drivers/infiniband/ulp/isert/ib_isert.c | 7 +++---- > 2 files changed, 5 insertions(+), 7 deletions(-) > > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html