From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbbL1KLa (ORCPT ); Mon, 28 Dec 2015 05:11:30 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:36166 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbbL1KLY (ORCPT ); Mon, 28 Dec 2015 05:11:24 -0500 Date: Mon, 28 Dec 2015 12:11:21 +0200 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: Matthew Wilcox , linux-mm@kvack.org, linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 1/8] mm: Add optional support for PUD-sized transparent hugepages Message-ID: <20151228101121.GB4589@node.shutemov.name> References: <1450974037-24775-1-git-send-email-matthew.r.wilcox@intel.com> <1450974037-24775-2-git-send-email-matthew.r.wilcox@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450974037-24775-2-git-send-email-matthew.r.wilcox@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 24, 2015 at 11:20:30AM -0500, Matthew Wilcox wrote: > The only major difference is how the new ->pud_entry method in mm_walk > works. The ->pmd_entry method replaces the ->pte_entry method, whereas > the ->pud_entry method works along with either ->pmd_entry or ->pte_entry. I think it makes pagewalk API confusing. We need something more coherent. -- Kirill A. Shutemov