linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Gross <andy.gross@linaro.org>
To: Bjorn Andersson <bjorn@kryo.se>
Cc: Eugene Krasnikov <k.eugene.e@gmail.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kalle Valo <kvalo@codeaurora.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, fengwei.yin@linaro.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	wcn36xx@lists.infradead.org
Subject: Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding
Date: Tue, 29 Dec 2015 13:11:12 -0600	[thread overview]
Message-ID: <20151229191112.GB27812@hector.attlocal.net> (raw)
In-Reply-To: <1451266467-15377-5-git-send-email-bjorn.andersson@sonymobile.com>

On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote:
> Add binding representing the Qualcomm wcn3620/60/80 WiFi block.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---

<snip>

> +
> +- qcom,wcnss-mmio:
> +	Usage: required
> +	Value type: <prop-encoed-array>

nit:  encoded

> +	Definition: should specify base address and size of the WiFi related
> +		    registers of WCNSS
> +
> +- qcom,state:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: should specify the tx-enable and tx-ring-empty state
> +		    references
> +

<snip>

Otherwise looks good.

Reviewed-by: Andy Gross <andy.gross@linaro.org>

      parent reply	other threads:[~2015-12-29 19:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-28  1:34 [PATCH 0/4] WCN36xx convert to mainline SMD interface Bjorn Andersson
2015-12-28  1:34 ` [PATCH 1/4] wcn36xx: Fold indication payload into message header Bjorn Andersson
2015-12-28  1:34 ` [PATCH 2/4] wcn36xx: Change indication list lock to spinlock Bjorn Andersson
2015-12-28 23:06   ` Stephen Hemminger
2015-12-29  4:25     ` Bjorn Andersson
2015-12-28  1:34 ` [PATCH 3/4] wcn36xx: Transition driver to SMD client Bjorn Andersson
2016-01-11  9:02   ` Eugene Krasnikov
2016-03-29  4:39     ` Bjorn Andersson
2015-12-28  1:34 ` [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding Bjorn Andersson
2015-12-29 18:34   ` Rob Herring
2015-12-29 19:03     ` Bjorn Andersson
2015-12-29 23:27       ` Rob Herring
2016-01-25 17:50       ` Bjorn Andersson
2015-12-29 19:11   ` Andy Gross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151229191112.GB27812@hector.attlocal.net \
    --to=andy.gross@linaro.org \
    --cc=bjorn@kryo.se \
    --cc=devicetree@vger.kernel.org \
    --cc=fengwei.yin@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=k.eugene.e@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wcn36xx@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).