From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbbL2Xfb (ORCPT ); Tue, 29 Dec 2015 18:35:31 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:22632 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752951AbbL2Xf3 (ORCPT ); Tue, 29 Dec 2015 18:35:29 -0500 Date: Wed, 30 Dec 2015 00:35:19 +0100 From: Willy Tarreau To: Ilia Mirkin Cc: Ksenija Stanojevic , Greg Kroah-Hartman , willy@meta-x.org, devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/5] Staging: panel: Remove ULL Message-ID: <20151229233519.GC13856@1wt.eu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 29, 2015 at 03:59:26PM -0500, Ilia Mirkin wrote: > On Tue, Dec 29, 2015 at 3:08 PM, Ksenija Stanojevic > wrote: > > Remove ULL since it's useless. > > > > Signed-off-by: Ksenija Stanojevic > > --- > > drivers/staging/panel/panel.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c > > index 7138ee7..6dc3efb 100644 > > --- a/drivers/staging/panel/panel.c > > +++ b/drivers/staging/panel/panel.c > > @@ -2047,10 +2047,10 @@ static u8 input_name2mask(const char *name, __u64 *mask, __u64 *value, > > u8 im, om; > > __u64 m, v; > > > > - om = 0ULL; > > - im = 0ULL; > > - m = 0ULL; > > - v = 0ULL; > > + om = 0; > > + im = 0; > > + m = 0; > > + v = 0; > > while (*name) { > > int in, out, bit, neg; > > > > @@ -2076,9 +2076,9 @@ static u8 input_name2mask(const char *name, __u64 *mask, __u64 *value, > > > > bit = (out * 5) + in; > > > > - m |= 1ULL << bit; > > + m |= 1 << bit; > > m and v are 64-bit, if bit can be >= 32, then you definitely do need > the ULL here... If that's it, indeed. I thought they were 8-bit from a previous patch. I'm sorry for having suggested this cleanup, I've not put my nose in this code for quite a while I must confess :-/ Regards, Willy