From: "Serge E. Hallyn" <serge.hallyn@ubuntu.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Serge E. Hallyn" <serge.hallyn@ubuntu.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-api@vger.kernel.org, containers@lists.linux-foundation.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
lxc-devel@lists.linuxcontainers.org,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: CGroup Namespaces (v8)
Date: Fri, 1 Jan 2016 12:06:33 -0600 [thread overview]
Message-ID: <20160101180633.GA30941@mail.hallyn.com> (raw)
In-Reply-To: <CAPcyv4iig_sujK=p0TbNjTmtv39N7a0HSqpVe8mLnfX9Es7zNA@mail.gmail.com>
On Fri, Jan 01, 2016 at 01:42:57AM -0800, Dan Williams wrote:
> On Fri, Jan 1, 2016 at 12:59 AM, Serge E. Hallyn
> <serge.hallyn@ubuntu.com> wrote:
> > On Fri, Jan 01, 2016 at 12:19:44AM -0800, Dan Williams wrote:
> >> On Tue, Dec 22, 2015 at 8:23 PM, <serge.hallyn@ubuntu.com> wrote:
> >> > Hi,
> >> >
> >> > following is a revised set of the CGroup Namespace patchset which Aditya
> >> > Kali has previously sent. The code can also be found in the cgroupns.v8
> >> > branch of
> >> >
> >> > https://git.kernel.org/cgit/linux/kernel/git/sergeh/linux-security.git/
> >>
> >> Happy New Year!
> >>
> >> I'm hitting both a build and boot regression in -next with these
> >> patches. The bisect log reports:
> >>
> >> git bisect skip f176ae3a5df610e0373c39538cc7744c7788b3df
> >> # bad: [54b39d263704b66cc8006ce8f7dd4743fdabae70] cgroup: cgroup
> >> namespace setns support
> >> git bisect bad 54b39d263704b66cc8006ce8f7dd4743fdabae70
> >> # good: [bf9b3590879afbaa54148d817ed68a0b51180375] sched: new clone
> >> flag CLONE_NEWCGROUP for c
> >> group namespace
> >> git bisect good bf9b3590879afbaa54148d817ed68a0b51180375
> >> # only skipped commits left to test
> >> # possible first bad commit:
> >> [54b39d263704b66cc8006ce8f7dd4743fdabae70] cgroup: cgroup namespa
> >> ce setns support
> >> # possible first bad commit:
> >> [f176ae3a5df610e0373c39538cc7744c7788b3df] cgroup: introduce cgro
> >> up namespaces
> >>
> >> Where compiling "f176ae3a5df6" fails with:
> >>
> >> kernel/cgroup.c: In function ‘cgroupns_put’:
> >> kernel/cgroup.c:5956:2: error: implicit declaration of function
> >> ‘to_cg_ns’ [-Werror=implicit-f
> >> unction-declaration]
> >> put_cgroup_ns(to_cg_ns(ns));
> >
> > Hi,
> >
> > is it possible you have a bad tree?
>
> No, I don't believe so...
>
> > Looking at
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/kernel/cgroup.c?id=refs/tags/next-20151231
> > to_cg_ns should definately be defined there.
> >
>
> Right, but it's not defined until commit 54b39d263704 "cgroup: cgroup
> namespace setns support", however it is first used in the preceeding
> commit f176ae3a5df6 "cgroup: introduce cgroup namespaces". The bad
> patch ordering breaks bisection.
>
> Commit 54b39d263704 "cgroup: cgroup namespace setns support" not
> booting is a separate issue.
Oh - been there since my first version of the set (v4). Odd, I
thought that the automated korg testing caught those.
What is the simplest way to fix this? Do I send new versions of
patches v3 and v4? Does Tejun or Stephen just do it inline in the
git tree? Do we leave it be?
next prev parent reply other threads:[~2016-01-01 18:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 4:23 CGroup Namespaces (v8) serge.hallyn
2015-12-23 4:23 ` [PATCH 1/8] kernfs: Add API to generate relative kernfs path serge.hallyn
2015-12-23 16:08 ` Tejun Heo
2015-12-23 16:36 ` Serge E. Hallyn
2015-12-23 19:33 ` [PATCH 1/8 v8.2] " Serge E. Hallyn
2015-12-23 16:24 ` [PATCH 1/8] " Tejun Heo
2015-12-23 16:51 ` Greg KH
2015-12-23 4:23 ` [PATCH 2/8] sched: new clone flag CLONE_NEWCGROUP for cgroup namespace serge.hallyn
2015-12-23 4:23 ` [PATCH 3/8] cgroup: introduce cgroup namespaces serge.hallyn
2015-12-23 16:15 ` Tejun Heo
2015-12-23 19:34 ` [PATCH 3/8 v8.2] " Serge E. Hallyn
2015-12-23 4:23 ` [PATCH 4/8] cgroup: cgroup namespace setns support serge.hallyn
2015-12-23 4:23 ` [PATCH 5/8] kernfs: define kernfs_node_dentry serge.hallyn
2015-12-23 16:25 ` Tejun Heo
2015-12-23 16:51 ` Greg KH
2015-12-23 4:23 ` [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init cgroupns serge.hallyn
2015-12-31 13:38 ` Sergey Senozhatsky
2016-01-01 0:58 ` Serge E. Hallyn
2016-01-01 1:17 ` Sergey Senozhatsky
2016-01-01 1:56 ` Tejun Heo
2015-12-23 4:23 ` [PATCH 7/8] cgroup: Add documentation for cgroup namespaces serge.hallyn
2015-12-28 17:47 ` Tejun Heo
2015-12-28 21:13 ` Serge Hallyn
2015-12-28 21:48 ` [PATCH] " Tejun Heo
2015-12-23 4:23 ` [PATCH 8/8] Add FS_USERNS_FLAG to cgroup fs serge.hallyn
2015-12-28 17:46 ` CGroup Namespaces (v8) Tejun Heo
2016-01-01 8:19 ` Dan Williams
2016-01-01 8:59 ` Serge E. Hallyn
2016-01-01 9:42 ` Dan Williams
2016-01-01 18:06 ` Serge E. Hallyn [this message]
2016-01-01 19:14 ` Dan Williams
2016-01-02 11:52 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160101180633.GA30941@mail.hallyn.com \
--to=serge.hallyn@ubuntu.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lxc-devel@lists.linuxcontainers.org \
--cc=sfr@canb.auug.org.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).