From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752211AbcACBpn (ORCPT <rfc822;w@1wt.eu>);
	Sat, 2 Jan 2016 20:45:43 -0500
Received: from shards.monkeyblade.net ([149.20.54.216]:33032 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751897AbcACBpk convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 2 Jan 2016 20:45:40 -0500
Date: Sat, 02 Jan 2016 20:45:35 -0500 (EST)
Message-Id: <20160102.204535.816844219039778167.davem@davemloft.net>
To: bjorn@mork.no
Cc: elfring@users.sourceforge.net, linux-usb@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr
Subject: Re: [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable
 initialisation in qmi_wwan_register_subdriver()
From: David Miller <davem@davemloft.net>
In-Reply-To: <87ziwnpt2v.fsf@nemi.mork.no>
References: <5686AE52.1020008@users.sourceforge.net>
	<5686AFAE.7020401@users.sourceforge.net>
	<87ziwnpt2v.fsf@nemi.mork.no>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 02 Jan 2016 17:45:39 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Bjørn Mork <bjorn@mork.no>
Date: Sat, 02 Jan 2016 22:30:48 +0100

> SF Markus Elfring <elfring@users.sourceforge.net> writes:
> 
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Fri, 1 Jan 2016 17:35:03 +0100
>>
>> Omit explicit initialisation at the beginning for one local variable
>> that is redefined before its first use.
> 
> 
> This patch is unnecessary. The variable initialisation is redundant.
> See the difference?  Sending an unnecessary patch causes unnecessary
> load on reviewers and maintainers.  Keeping redundant code has no
> measurable cost, and can save the same maintainers a lot of trouble
> later.

+1

I'm getting really tired of these changes.  And a lot of them are
coming in right now...