From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751646AbcABOSH (ORCPT <rfc822;w@1wt.eu>);
	Sat, 2 Jan 2016 09:18:07 -0500
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60003 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750861AbcABOSF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 2 Jan 2016 09:18:05 -0500
Date: Sat, 2 Jan 2016 14:17:46 +0000
From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Brian Austin <brian.austin@cirrus.com>,
        Paul Handrigan <Paul.Handrigan@cirrus.com>,
        Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Message-ID: <20160102141746.GH16023@sirena.org.uk>
References: <2884997.s8B8BuE04L@wuerfel>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="lo/yIdJSCXpBJBdU"
Content-Disposition: inline
In-Reply-To: <2884997.s8B8BuE04L@wuerfel>
X-Cookie: Honk if you love peace and quiet.
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: 2a01:348:6:808::2
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH] ASoC: cs35l32: avoid uninitialized variable access
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--lo/yIdJSCXpBJBdU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jan 02, 2016 at 12:19:52AM +0100, Arnd Bergmann wrote:

> -		if (i2c_client->dev.of_node) {
> +		if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) {

This would be a lot nicer if there was an __always_null annotation we
could put on of_node for !OF configurations, that'd Just Work and this
can't be the only case where we have this idiom.

--lo/yIdJSCXpBJBdU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWh9wJAAoJECTWi3JdVIfQMp4H/0L06vOLZu11OJAYdazD2Ezn
TTpfbYQ3TA3rKsIoxCJJJlk1l96kGuyk4JSjqaWTuo4vTIMNyxuKm/f8t/A32KUV
Xg3eW50oy4i/ykbaf79psPYXuKiEYkDhrNQxjiOLRgmVlnUsGhY7GEoFXOoRAERu
AuOjga5OYKB9jPBWxuXHn+3jO0PKFCdsOh4+hF1we7xdE8h5bRSVErM7VxFNd/EA
jxr4elwxnMexo85Vi08ahoDQ6cRQ+XzU6szGGjONifmlQmChDg1lFlTCdkgweAGu
mzBlwVV4vj4w8/wzue/qtcPvihuDeEmGIa+fjDralakarbBAIVJXaS/WZOl9wCc=
=S5mv
-----END PGP SIGNATURE-----

--lo/yIdJSCXpBJBdU--