From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753054AbcADI1b (ORCPT ); Mon, 4 Jan 2016 03:27:31 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:34419 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397AbcADI12 (ORCPT ); Mon, 4 Jan 2016 03:27:28 -0500 Date: Mon, 4 Jan 2016 09:27:25 +0100 From: Thierry Reding To: Arnd Bergmann Cc: David Airlie , linux-arm-kernel@lists.infradead.org, Liviu Dudau , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: arm-hdlcd: remove DMA_CMA select Message-ID: <20160104082725.GE23797@ulmo> References: <4194408.X82ccDjh5X@wuerfel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T6xhMxlHU34Bk0ad" Content-Disposition: inline In-Reply-To: <4194408.X82ccDjh5X@wuerfel> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --T6xhMxlHU34Bk0ad Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 01, 2016 at 03:09:10PM +0100, Arnd Bergmann wrote: > The newly added DRM_HDLCD driver tries to select DMA_CMA, but that is > not necessarily possible, as not all configurations contain HAVE_DMA_CONT= IGUOUS: >=20 > warning: (DRM_HDLCD) selects DMA_CMA which has unmet direct dependencies = (HAVE_DMA_CONTIGUOUS && CMA) > drivers/built-in.o: In function `dma_alloc_from_contiguous': > :(.text+0x1dee00): undefined reference to `cma_alloc' > drivers/built-in.o: In function `dma_release_from_contiguous': > :(.text+0x1dee24): undefined reference to `cma_release' >=20 > This removes the 'select' statement. It is not needed because CMA is meant > to transparently change the behavior of dma_alloc_coherent to make it suc= ceed > for larger allocations, but there is no actual build-time dependency, and > the driver can still work without CMA in many cases. >=20 > Signed-off-by: Arnd Bergmann > Fixes: 1561e558334d ("drm: Add support for ARM's HDLCD controller.") > --- > Found on ARM randconfig builds with yesterday's linux-next Reviewed-by: Thierry Reding --T6xhMxlHU34Bk0ad Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWiiztAAoJEN0jrNd/PrOh9JoQAJCiuoPyRs5RKdKjGfrMfLfM F0HeZRYZFpwJiGAwAtsMkRiOOrPI3IEIRKSkl5kgV5JjgODyjY398XTdZOfFwrmx gJKNmfsl83LJ3qFi/cSfFF58ah5XhmVVUhrRjm+epZnY91stmaK5o1fv1Nf6CHY2 35P3AgRrZ3VmppbNWBxLdfu9nhMEx6+g32JMjBkkgpjtCTHwPYlEUATV+j9+dmVa SQmTCiWBaoUDD3qfXd0jnpCvrppWveivOPpSGZLylObNTovg83Cnf99MnZoaeuvH p7c4QtdZViM5NEBmlP8dRXcDGS3ejvEogZXc7kxX6DHMwzpNS8RMwis3aI8Zbkhk Pbw/wLwrDzKPtjqGosAH7oLjdXEO/HZ36rit8ao6hvVNn2eh4o1Lb27bUeyiv/dR lO6pVZUrRXrxNgC+quRUOn7/2lrzAe50SyMNpZo4jQL3LNlkuQIMqBMSgpDIGbdP U/G3eDx5D+xFAk2qlU7Iae5YVTbjswj1mfy5FIMlt4f+2+v3rcuc0wOHq137gIxm ubsh+a7weQ0gtjb2xNJScmHus7vDmBTwBmB76gA/P/PjAn7uKiohatoowT2eDdI4 5kO6+mIFFe8kBWohy4AaogDpYhRhqt71BCLN7zLj4zGc7LPfr2Qo6LfYQf8YcQ9Y OuH8PQ1fEFaVSDmlowfF =Xdm8 -----END PGP SIGNATURE----- --T6xhMxlHU34Bk0ad--