From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753503AbcADLay (ORCPT ); Mon, 4 Jan 2016 06:30:54 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:51452 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbcADLaw (ORCPT ); Mon, 4 Jan 2016 06:30:52 -0500 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: kernel-janitors@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Mon, 4 Jan 2016 12:30:46 +0100 From: Heiko Carstens To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, Martin Schwidefsky , Ursula Braun , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() Message-ID: <20160104113046.GE4179@osiris> References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F1D0.3090502@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5688F1D0.3090502@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16010411-0041-0000-0000-000006D2C2A1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 03, 2016 at 11:02:56AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 10:50:11 +0100 > > Reduce the scope for the local variable "def_discipline" to one branch > of an if statement. > > Signed-off-by: Markus Elfring > --- > drivers/s390/net/qeth_core_main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c > index 54fde2e..3261977 100644 > --- a/drivers/s390/net/qeth_core_main.c > +++ b/drivers/s390/net/qeth_core_main.c > @@ -5638,9 +5638,10 @@ static int qeth_core_set_online(struct ccwgroup_device *gdev) > { > struct qeth_card *card = dev_get_drvdata(&gdev->dev); > int rc; > - int def_discipline; > > if (!card->discipline) { > + int def_discipline; > + > if (card->info.type == QETH_CARD_TYPE_IQD) > def_discipline = QETH_DISCIPLINE_LAYER3; Same here: I don't think we want to start with patches like this. This going to be a never ending story without much benefit.