From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Pavel Machel <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
Nishanth Menon <nm@ti.com>, Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Nokia N900: twl4030-power different data in DTS and board code
Date: Mon, 4 Jan 2016 08:50:39 -0800 [thread overview]
Message-ID: <20160104165039.GB12777@atomide.com> (raw)
In-Reply-To: <201601022239.27379@pali>
* Pali Rohár <pali.rohar@gmail.com> [160102 13:39]:
> On Saturday 02 January 2016 18:14:31 Tony Lindgren wrote:
>
> > The n900 specific code was based on something before the TI generic
> > values were available I think. And the last time I looked at it I
> > came to the conclusion the n900 specific code is no better.
>
> Hm... if generic values are better, why old values are still there (in
> board n900 code)?
We never had PM working in a generic way for the legacy booting but
relied on board specific configuration instead for the ones that did
work. Probably not worth changing the board-*.c file configuration
unless you want to test that the new generic settings work.
> > Or did I miss something? Are you seeing some issues with PM with dts
> > based code?
>
> I'm just asking why we have different code for DST and board...
OK. Yeah no reason beyond somebody taking the time to verify that the
generic settings work on n900 in legacy booting mode :)
> > We can certainly add it to twl4030-power if it provides something
> > that the "ti,twl4030-power-idle-osc-off" does not.
>
> But do we need 'compatible = "ti,twl4030-power-n900"' specification in
> omap3-n900.dts file at all?
Well that generally done to allow adding support for the board specific
configuration if needed with a fallback to the generic configuration.
That's used quite a bit, for example boards typically set the compatible
to the specific board but still end up booting with a generic one
sucha as "ti,omap3".
Regards,
Tony
prev parent reply other threads:[~2016-01-04 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 14:13 Nokia N900: twl4030-power different data in DTS and board code Pali Rohár
2016-01-02 17:14 ` Tony Lindgren
2016-01-02 21:39 ` Pali Rohár
2016-01-04 16:50 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104165039.GB12777@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).