From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752991AbcADSYs (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Jan 2016 13:24:48 -0500
Received: from quartz.orcorp.ca ([184.70.90.242]:49213 "EHLO quartz.orcorp.ca"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752416AbcADSYn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Jan 2016 13:24:43 -0500
Date: Mon, 4 Jan 2016 11:24:42 -0700
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        Martin Wilck <Martin.Wilck@ts.fujitsu.com>,
        Peter Huewe <peterhuewe@gmx.de>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a
 per-device basis
Message-ID: <20160104182442.GC20016@obsidianresearch.com>
References: <1450376600-6970-1-git-send-email-jgunthorpe@obsidianresearch.com>
 <1450376600-6970-3-git-send-email-jgunthorpe@obsidianresearch.com>
 <20160103172040.GB4155@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160103172040.GB4155@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 03, 2016 at 07:20:40PM +0200, Jarkko Sakkinen wrote:
> On Thu, Dec 17, 2015 at 11:23:15AM -0700, Jason Gunthorpe wrote:
> > Instead of clearing the global interrupts flag when any device
> > does not have an interrupt just pass -1 through tpm_info.irq.
> > 
> > The only thing that asks for autoprobing is the force=1 path.
> 
> Sorry for my ignorance but what does this patch help? Why interrupts
> flag is not enough?

It is wrong for a driver's probe function to change global state, and
very wrong to change a module option.

> > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > Tested-by: Wilck, Martin <martin.wilck@ts.fujitsu.com>
> > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> Did I already give Tested-by's for this series (I did for those that
> went into v4.5 pull request)?

You said you tested the crb stuff, which is this series... Did you
test something else?

Jason