From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbcADS14 (ORCPT ); Mon, 4 Jan 2016 13:27:56 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:45579 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbcADS1y (ORCPT ); Mon, 4 Jan 2016 13:27:54 -0500 Date: Mon, 4 Jan 2016 11:27:53 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Martin Wilck , Peter Huewe , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v3 5/7] tpm_tis: Clean up the force=1 module parameter Message-ID: <20160104182753.GD20016@obsidianresearch.com> References: <1450376600-6970-1-git-send-email-jgunthorpe@obsidianresearch.com> <1450376600-6970-6-git-send-email-jgunthorpe@obsidianresearch.com> <20160103172650.GD4155@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160103172650.GD4155@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 03, 2016 at 07:26:50PM +0200, Jarkko Sakkinen wrote: > > @@ -695,8 +685,8 @@ static int tpm_tis_init(struct device *dev, struct tpm_info *tpm_info, > > #endif > > > > chip->vendor.iobase = devm_ioremap_resource(dev, &tpm_info->res); > > - if (!chip->vendor.iobase) > > - return -EIO; > > + if (IS_ERR(chip->vendor.iobase)) > > + return PTR_ERR(chip->vendor.iobase); > > Isn't this a regression in the descendig patch in this series? Oh yes, good catch. The fix from Martin got rebased onto the wrong patch by accident. Jason