From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbcADScy (ORCPT ); Mon, 4 Jan 2016 13:32:54 -0500 Received: from mga02.intel.com ([134.134.136.20]:49550 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753080AbcADScu (ORCPT ); Mon, 4 Jan 2016 13:32:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,521,1444719600"; d="scan'208";a="23445650" Date: Mon, 4 Jan 2016 20:32:42 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Martin Wilck , Peter Huewe , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v3 2/7] tpm_tis: Disable interrupt auto probing on a per-device basis Message-ID: <20160104183242.GA16334@intel.com> References: <1450376600-6970-1-git-send-email-jgunthorpe@obsidianresearch.com> <1450376600-6970-3-git-send-email-jgunthorpe@obsidianresearch.com> <20160103172040.GB4155@intel.com> <20160104182442.GC20016@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160104182442.GC20016@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 11:24:42AM -0700, Jason Gunthorpe wrote: > On Sun, Jan 03, 2016 at 07:20:40PM +0200, Jarkko Sakkinen wrote: > > On Thu, Dec 17, 2015 at 11:23:15AM -0700, Jason Gunthorpe wrote: > > > Instead of clearing the global interrupts flag when any device > > > does not have an interrupt just pass -1 through tpm_info.irq. > > > > > > The only thing that asks for autoprobing is the force=1 path. > > > > Sorry for my ignorance but what does this patch help? Why interrupts > > flag is not enough? > > It is wrong for a driver's probe function to change global state, and > very wrong to change a module option. I disagree about global state in some sense but module options should stay static. That's much better argument. > > > Signed-off-by: Jason Gunthorpe > > > Tested-by: Wilck, Martin > > > Tested-by: Jarkko Sakkinen > > > > Did I already give Tested-by's for this series (I did for those that > > went into v4.5 pull request)? > > You said you tested the crb stuff, which is this series... Did you > test something else? Checked my emails. Right I did run my tests for this (both with FIFO and CRB driver). It was bit "stormy" before Christmas with all kinds of small patches so I wasn't sure. Reviewed-by: Jarkko Sakkinen > Jason /Jarkko