From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753312AbcADSeh (ORCPT ); Mon, 4 Jan 2016 13:34:37 -0500 Received: from mail.kernel.org ([198.145.29.136]:38579 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752811AbcADSed (ORCPT ); Mon, 4 Jan 2016 13:34:33 -0500 Date: Mon, 4 Jan 2016 15:34:28 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: Namhyung Kim , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Frederic Weisbecker , Andi Kleen , Wang Nan Subject: Re: [PATCH v4.1 03/13] tools lib traceevent: Factor out and export print_event_field[s] Message-ID: <20160104183428.GC5462@kernel.org> References: <1450804030-29193-4-git-send-email-namhyung@kernel.org> <1450876121-22494-1-git-send-email-namhyung@kernel.org> <20160104103127.786a2b8e@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160104103127.786a2b8e@gandalf.local.home> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jan 04, 2016 at 10:31:27AM -0500, Steven Rostedt escreveu: > On Wed, 23 Dec 2015 22:08:41 +0900 > Namhyung Kim wrote: > > > The print_event_field() and print_event_fields() are to print basic > > information of a given field or event without the print format. They'll > > be used by dynamic sort keys later. > > Hi Namhyung, > > > > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h > > index 6fc83c7edbe9..600c73277a6f 100644 > > --- a/tools/lib/traceevent/event-parse.h > > +++ b/tools/lib/traceevent/event-parse.h > > @@ -705,6 +705,10 @@ struct cmdline *pevent_data_pid_from_comm(struct pevent *pevent, const char *com > > struct cmdline *next); > > int pevent_cmdline_pid(struct pevent *pevent, struct cmdline *cmdline); > > > > +void print_event_field(struct trace_seq *s, void *data, > > + struct format_field *field); > > +void print_event_fields(struct trace_seq *s, void *data, > > + int size __maybe_unused, struct event_format *event); > > I'm fine with the patch, but can you change the function names to be > less generic, as this will now be part of a library (that I hope will > become something supplied by distros soon). > > Like: > > pevent_print_field(); > and > pevent_print_fields(); Sure, I did those changes in my tree as we discussed over IRC, as well added your Acked-by, thanks, - Arnaldo > Thanks! > > -- Steve > > > void pevent_event_info(struct trace_seq *s, struct event_format *event, > > struct pevent_record *record); > > int pevent_strerror(struct pevent *pevent, enum pevent_errno errnum,