From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753344AbcADUnl (ORCPT ); Mon, 4 Jan 2016 15:43:41 -0500 Received: from mail5.windriver.com ([192.103.53.11]:49019 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752494AbcADUnj (ORCPT ); Mon, 4 Jan 2016 15:43:39 -0500 Date: Mon, 4 Jan 2016 15:43:25 -0500 From: Paul Gortmaker To: Sudip Mukherjee CC: , Nicolas Ferre , Jiri Slaby , , Greg Kroah-Hartman , Sudip Mukherjee Subject: Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c Message-ID: <20160104204324.GP12458@windriver.com> References: <1450364746-815-1-git-send-email-paul.gortmaker@windriver.com> <20160102074740.GA11430@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160102074740.GA11430@sudip-pc> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c] On 02/01/2016 (Sat 13:17) Sudip Mukherjee wrote: > On Thu, Dec 17, 2015 at 10:05:46AM -0500, Paul Gortmaker wrote: > > In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial: > > make serial/atmel_serial.c explicitly non-modular") we removed the code > > relating to modular support since it currently only supports built in. > > > > However, when redoing my build coverage for mips allmodconfig, which > > sets CONFIG_OF, I noticed a remaining line that needs to be removed, > > else we will get a build failure for an undefined module macro. > > > > Unfortunately this didn't appear for any of the other arch I tested > > more frequently, such as ARM. > > > > Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just > > remove the offending line. > > > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular") > > Cc: Nicolas Ferre > > Cc: Jiri Slaby > > Cc: linux-serial@vger.kernel.org > > Cc: Greg Kroah-Hartman > > Cc: Sudip Mukherjee > > Reported-by: Sudip Mukherjee > > Signed-off-by: Paul Gortmaker > > --- > > I think this has not yet landed in linux-next. next-20151231 still > fails. Greg has a lot of irons in the fire, and it is also the season where a lot of people have unplugged for the last two weeks to be with family, friends, etc, so lets be patient. Thanks, Paul. -- > > regards > sudip