From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbcAEHy7 (ORCPT ); Tue, 5 Jan 2016 02:54:59 -0500 Received: from e06smtp05.uk.ibm.com ([195.75.94.101]:45245 "EHLO e06smtp05.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbcAEHyx (ORCPT ); Tue, 5 Jan 2016 02:54:53 -0500 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: kernel-janitors@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Tue, 5 Jan 2016 08:54:46 +0100 From: Heiko Carstens To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, Martin Schwidefsky , Ursula Braun , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: 390/qeth: Refactoring for qeth_core_set_online() Message-ID: <20160105075446.GA3432@osiris> References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F1D0.3090502@users.sourceforge.net> <20160104113046.GE4179@osiris> <568A6F4A.1000206@users.sourceforge.net> <20160104140447.GG4179@osiris> <568A7D61.90703@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <568A7D61.90703@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16010507-0021-0000-0000-00000558A823 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 04, 2016 at 03:10:41PM +0100, SF Markus Elfring wrote: > > In this case the function body is very small > > so I don't see any benefit at all. > > Do you care for fine-tuning of variable placement occasionally? No.