From: Wolfram Sang <wsa@the-dreams.de>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Simon Horman <horms@verge.net.au>,
Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 3/4] PCI: rcar: Add runtime PM support to pcie-rcar
Date: Wed, 6 Jan 2016 09:35:01 +0100 [thread overview]
Message-ID: <20160106083500.GB1525@katana> (raw)
In-Reply-To: <1451998831-27705-4-git-send-email-phil.edworthy@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 149 bytes --]
> +err_pm_put:
> + pm_runtime_put(pcie->dev);
> +
> +err_pm_disable:
> + pm_runtime_disable(pcie->dev);
What about put/disable in the remove part?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-06 8:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 13:00 [PATCH v2 0/4] Various R-Car PCIe patches Phil Edworthy
2016-01-05 13:00 ` [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar Phil Edworthy
2016-01-08 1:50 ` Simon Horman
2016-01-08 21:06 ` Bjorn Helgaas
2016-01-11 11:23 ` Phil Edworthy
2016-01-05 13:00 ` [PATCH v2 2/4] PCI: rcar: Support runtime PM link state L1 handling " Phil Edworthy
2016-01-06 8:35 ` Wolfram Sang
2016-01-08 21:31 ` Bjorn Helgaas
2016-01-11 11:42 ` Phil Edworthy
2016-01-13 16:58 ` Phil Edworthy
2016-01-05 13:00 ` [PATCH v2 3/4] PCI: rcar: Add runtime PM support to pcie-rcar Phil Edworthy
2016-01-06 8:35 ` Wolfram Sang [this message]
2016-01-06 8:45 ` Geert Uytterhoeven
2016-01-06 8:50 ` Wolfram Sang
2016-01-05 13:00 ` [PATCH v2 4/4] PCI: rcar: Add Gen2 PHY setup " Phil Edworthy
2016-01-06 8:39 ` Wolfram Sang
2016-01-11 14:48 ` [PATCH v2 0/4] Various R-Car PCIe patches Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106083500.GB1525@katana \
--to=wsa@the-dreams.de \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).