From: Kalle Valo <kvalo@codeaurora.org>
To: Jia-Ju Bai <baijiaju1990@163.com>
Cc: sgruszka@redhat.com, helmut.schaa@googlemail.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Jia-Ju Bai <baijiaju1990@163.com>
Subject: Re: rt2x00pci: Disable memory-write-invalidate when the driver exits
Date: Thu, 7 Jan 2016 09:23:07 +0000 (UTC) [thread overview]
Message-ID: <20160107092307.76F55605BD@smtp.codeaurora.org> (raw)
In-Reply-To: <1451894138-3482-1-git-send-email-baijiaju1990@163.com>
> The driver calls pci_set_mwi to enable memory-write-invalidate when it
> is initialized, but does not call pci_clear_mwi when it is removed. Many
> other drivers calls pci_clear_mwi when pci_set_mwi is called, such as
> r8169, 8139cp and e1000.
>
> This patch adds pci_clear_mwi in error handling and removal procedure,
> which can fix the problem.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
> Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
prev parent reply other threads:[~2016-01-07 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 7:55 [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits Jia-Ju Bai
2016-01-04 16:50 ` Helmut Schaa
2016-01-05 1:27 ` Jia-Ju Bai
2016-01-05 10:17 ` Helmut Schaa
2016-01-07 9:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107092307.76F55605BD@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=baijiaju1990@163.com \
--cc=helmut.schaa@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).