From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752245AbcAGKLg (ORCPT ); Thu, 7 Jan 2016 05:11:36 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:39122 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254AbcAGKLc convert rfc822-to-8bit (ORCPT ); Thu, 7 Jan 2016 05:11:32 -0500 From: Juergen Borleis Organization: Pengutronix e.K. To: kernel@pengutronix.de Subject: Re: [PATCH 3/3] RTC/PCF85063: fix time/date setting Date: Thu, 7 Jan 2016 11:13:00 +0100 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org References: <1449496174-7813-1-git-send-email-jbe@pengutronix.de> <1449496174-7813-4-git-send-email-jbe@pengutronix.de> In-Reply-To: <1449496174-7813-4-git-send-email-jbe@pengutronix.de> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <201601071113.00076.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, sorry, missed your comment. Please keep me on CC since I'm not subscribed to the list. > > When setting a new time/date the RTC's clock must be stopped first, in > > order to write the time/date registers in an atomic manner. > > So, this change stops the clock first and then writes the time/date > > registers and the clock control register (to re-enable the clock) in one > > turn. > > I'd have the same comment for that patch. Using > i2c_smbus_write_byte_data and i2c_smbus_write_block_data would make the > code clearer and also more robust because it takes care of > retransmissions for example. Okay. Will have a look. Regards, Juergen -- Pengutronix e.K.                              | Juergen Borleis             | Industrial Linux Solutions                    | http://www.pengutronix.de/  |