On Tue, Jan 05, 2016 at 09:50:54PM +0000, Måns Rullgård wrote: > Cyrille Pitchen writes: > > + as->use_cs_gpios = true; > > + if (atmel_spi_is_v2(as) && > > + !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) { > > + as->use_cs_gpios = false; > > + master->num_chipselect = 4; > > + } > This part breaks the AVR32 boards and probably anything else that > doesn't use devicetree but does use GPIOs for chip select. Shouldn't this just be setting defaults for the case where nothing is provided?