From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753539AbcAGPuf (ORCPT ); Thu, 7 Jan 2016 10:50:35 -0500 Received: from mail-qk0-f180.google.com ([209.85.220.180]:35306 "EHLO mail-qk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbcAGPue (ORCPT ); Thu, 7 Jan 2016 10:50:34 -0500 Date: Thu, 7 Jan 2016 10:50:32 -0500 From: Tejun Heo To: wanghaibin Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, peter.huangpeng@huawei.com Subject: Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed. Message-ID: <20160107155032.GB1898@mtj.duckdns.org> References: <1452170339-26748-1-git-send-email-wanghaibin.wang@huawei.com> <1452170339-26748-3-git-send-email-wanghaibin.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452170339-26748-3-git-send-email-wanghaibin.wang@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2016 at 08:38:57PM +0800, wanghaibin wrote: > Before the return that wq_numa_init failed, it will be bettet to free > the numa node table to avoid the memory leaks. That's a WARN_ON condition which should never happen. The system is already pretty messed up and just limping along. It really doesn't matter whether some memory is cleaned up or not. Let's keep it simple. Thanks. -- tejun